Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Python versions above 3.4 #330

Closed
wants to merge 1 commit into from
Closed

Support all Python versions above 3.4 #330

wants to merge 1 commit into from

Conversation

strokirk
Copy link

Hi,

Python 3.10 is released, and the only thing preventing transifex-client from using it is the setup.py configuration.

For ease of review I just performed the same changes as #306 .

If it seems reasonable, I'd be glad to update the python_requires line to allow all Python versions above 3.4 instead (so I can experiment with 3.11 easier 馃槉).

tox.ini Outdated Show resolved Hide resolved
@kaapstorm
Copy link

I agree with the idea of dropping 3.11 as the max Python version in python_requires. If we're worried about breaking changes in Python, how about python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,<4" instead?

kaapstorm added a commit to dimagi/commcare-hq that referenced this pull request Oct 15, 2021
The gevent upgrade is not as drastic as it looks. It counts versions
differently now. The bug fixes would be good to get in.

From transifex-client version 0.13.0 they specify a max Python version.
There is an [open PR][1] to support Python 3.10. I hope they fix their
broken build, and get it merged and released soon.

  [1]: transifex/transifex-client#330
kaapstorm added a commit to dimagi/commcare-hq that referenced this pull request Oct 18, 2021
The gevent upgrade is not as drastic as it looks. It counts versions
differently now. The bug fixes would be good to get in.

From transifex-client version 0.13.0 they specify a max Python version.
There is an [open PR][1] to support Python 3.10. I hope they fix their
broken build, and get it merged and released soon.

  [1]: transifex/transifex-client#330
m-aciek
m-aciek previously approved these changes Oct 24, 2021
@m-aciek m-aciek mentioned this pull request Oct 24, 2021
tk0miya added a commit to tk0miya/sphinx that referenced this pull request Oct 25, 2021
The latest transifex-client could not be installed on python 3.10
environment.  This downgrade python to 3.9 to be install the latest one.

ref: transifex/transifex-client#330
@strokirk strokirk changed the title Support Python 3.10 Support all Python versions above 3.4 Oct 25, 2021
@strokirk
Copy link
Author

I've updated the PR to simply allow all modern Python 3 subversions.

@goapunk
Copy link

goapunk commented Jan 12, 2022

any chance that this will get merged soon? :) It's quite a blocker since many distros ship with python 3.10

@strokirk
Copy link
Author

Ping @kostasgian , anything I need to change for this PR to be merged?

@kostasgian
Copy link
Contributor

kostasgian commented Jan 14, 2022

Hi @strokirk , nice work!
Please consider squashing the commits and please check of the failed checks!

You need to know though, that this client will soon be deprecated and will be replaced by the new tx client.

@strokirk
Copy link
Author

Hi @kostasgian , thanks for the response! I've rebased on the latest master.

Is the new tx client out of alpha? Congratulations in that case!

For some reason the tests fail on Python 2.7.

ERROR:   py27-vanilla: InvocationError for command /root/transifex/transifex-client/.tox/py27-vanilla/bin/pip install -U --exists-action w .tox/.tmp/package/1/transifex-client-0.14.4.zip (exited with code 1)
ERROR:   py27-pyopenssl: InvocationError for command /root/transifex/transifex-client/.tox/py27-pyopenssl/bin/pip install -U --exists-action w .tox/.tmp/package/1/transifex-client-0.14.4.zip (exited with code 1)

@kostasgian
Copy link
Contributor

Hi @strokirk , we removed the alpha label from the new tx client and we are promoting it now as the default client for transifex.

Now as far as it concerns the test fails I need to find some time first in order to take a look...

@ThiefMaster
Copy link

Can this PLEASE be merged and released? It's been more than half a year, and transifex-client STILL fails to install on 3.10...

@ThiefMaster
Copy link

OK, looks like there's a new CLI. Being able to install the old one with pip as part of the dev requirements was pretty convenient... Maybe archive the repo if this one is dead?

@strokirk
Copy link
Author

strokirk commented Jun 16, 2022

@ThiefMaster Just a heads up that the new CLI is quite a bit slower, and hard to install. So it might be wise to invest in automating the tx runs in a CI actions or something similar.

Our company is working on an asdf plugin and Github Action to simplify installation, I'll post it here once it's up!

@strokirk strokirk closed this by deleting the head repository Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants