Make Appcompat dependency optional #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txsdk's build.gradle declared an "implementation" dependency to 'androidx.appcompat:appcompat:1.2.0'. The dependency is now changed to "compile-only". This way, we are not adding Appcompat to an app that is not already using Appcompat. Special care was taken for accessing Appcompat methods and classes, as doing so in an app that is not using Appcompat will result in a crash, since the Appcompat classes will not be found at runtime. Utils#isAppcompatPresent() is used before accessing an Appcompat class. Removing Appcompat also affects multilingual support since Appcompat adds some strings which are localized in lots of locales. Readme was updated with extended instructions in case Appcompat is not used. 'androidx.annotation:annotation' dependency has been changed from "implementation" to "compileOnly", as it is only needed at compile time (and when building the javadoc). Since "compileOnly" dependencies are not inherited by the test sourcesets, it had to be redeclared using "testCompileOnly".
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txsdk's build.gradle declared an "implementation" dependency to
'androidx.appcompat:appcompat:1.2.0'. The dependency is now changed to
"compile-only". This way, we are not adding Appcompat to an app that is not
already using Appcompat.
Special care was taken for accessing Appcompat methods and classes, as
doing so in an app that is not using Appcompat will result in a crash, since the
Appcompat classes will not be found at runtime. Utils#isAppcompatPresent()
is used before accessing an Appcompat class.
Removing Appcompat also affects multilingual support since Appcompat adds some
strings which are localized in lots of locales. Readme was updated with extended
instructions in case Appcompat is not used.
'androidx.annotation:annotation' dependency has been changed from "implementation" to
"compileOnly", as it is only needed at compile time (and when building the javadoc).
Since "compileOnly" dependencies are not inherited by the test sourcesets, it had to be
redeclared using "testCompileOnly".