This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
Fixes Windows paths not resolving correctly #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@transitive-bullshit as a follow up. The issue lies with globby. A couple of days ago you updated the globby version to 11.0.0 from 9.0.0. They seem to have changed how they resolve paths for windows. This in turns also affects |
|
Thanks @antondelorme -- this is super helpful. I just want to make sure this doesn't cause any issues with non-Windows before merging. |
transitive-bullshit
approved these changes
Apr 1, 2020
|
Published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
Only tested on Windows though