This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
The typescript mode doesn't use Typescript in the example create-react-app #118 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried running the |
|
|
|
Awesome, thanks @nsisodiya! |
|
@transitive-bullshit but build is failing. |
|
package-lock.json was missing. So I added. |
|
@nsisodiya would you mind adding it in a new PR? this one's already merged? Thanks again! |
|
build started failing on this commit. - d18f62e |
|
Still example project is not in typescript. |
|
I just had a look and it looks like it is typescript. Where do you see that? |
Yes it is working. sorry for my previous message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have converted the example folder to typescript mode.