Merge pull request #1163 from transitland/ssp-interpolation-error-ski…

…p-trip SSP: Skip trip if interpolation issues
transitland · Aug 11, 2017 · 762f174 · 762f174
2 parents a856068 + d5f9987
commit 762f174
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/app/models/schedule_stop_pair.rb b/app/models/schedule_stop_pair.rb
@@ -296,6 +296,8 @@ def self.interpolate(ssps, method=:linear)
   def self.interpolate_linear(group)
     window_start = GTFS::WideTime.parse(group.first.origin_departure_time)
     window_end = GTFS::WideTime.parse(group.last.destination_arrival_time)
+    fail StandardError.new("First stop in trip must have a departure time") unless window_start
+    fail StandardError.new("Last stop in trip must have an arrival time") unless window_end
     duration = window_end.to_seconds - window_start.to_seconds
     step = duration / group.size.to_f
     current = window_start.to_seconds

diff --git a/app/services/gtfs_schedule_importer.rb b/app/services/gtfs_schedule_importer.rb
@@ -236,7 +236,12 @@ def make_ssp_trip(gtfs_trip, gtfs_stop_times, gtfs_frequency: nil)
     end
 
     # Interpolate stop_times
-    ScheduleStopPair.interpolate(ssp_trip)
+    begin
+      ScheduleStopPair.interpolate(ssp_trip)
+    rescue StandardError => e
+      info("Trip #{gtfs_trip.trip_id}: Could not process arrival/departure times, skipping: #{e.message}")
+      return []
+    end
 
     # Skip trip if validation errors
     unless ssp_trip.map(&:valid?).all?