Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or reduce "false positive" issues #846

Closed
1 of 2 tasks
doublestranded opened this issue Oct 31, 2016 · 1 comment · Fixed by #847 or #917
Closed
1 of 2 tasks

Remove or reduce "false positive" issues #846

doublestranded opened this issue Oct 31, 2016 · 1 comment · Fixed by #847 or #917
Assignees
@doublestranded
Labels
issues / quality checks

Comments

@doublestranded
Copy link
Contributor

doublestranded commented Oct 31, 2016 •
edited
Loading

  • "has the same distance" issue if stops have the same coordinates should be removed
  • closing "false positive" issues should remain closed
@doublestranded doublestranded self-assigned this Oct 31, 2016
@doublestranded
Copy link
Contributor Author

One possible solution to #2 is to have an attribute boolean or enum that signifies the issue is closed, but will remain persisted. Whenever a new changeset (or just import for performance?) finds the same issue, it will adopt the same attribute value.

@doublestranded doublestranded mentioned this issue Oct 31, 2016
Merged
@doublestranded doublestranded mentioned this issue Jan 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doublestranded doublestranded

Labels
issues / quality checks
Projects
None yet
Milestone
No milestone
1 participant
@doublestranded