Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exclude_geometry false default to include_geometry true #939

Closed
rmglennon opened this issue Jan 26, 2017 · 1 comment · Fixed by #944
Closed

Change exclude_geometry false default to include_geometry true #939

rmglennon opened this issue Jan 26, 2017 · 1 comment · Fixed by #944
Assignees

Comments

@rmglennon
Copy link

rmglennon commented Jan 26, 2017

In release 55, there's a new property for exclude_geometry. See #866

If the default of exclude_geometry == false, it means the normal behavior is to return the geometry.

After some discussion, let's consider changing this to a positive so users don't have to think as much. We can do this by making it include_geometry and the default be true.

(The alternative suggestion was to make the property be something like geometry with values of include and exclude instead of a boolean, so do whatever is most consistent with other properties in the datastore.)

@doublestranded
Copy link
Contributor

Make sure to keep backwards compatibility with 'exclude_geometry'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants