Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when logging exceptions to Sentry, include context #1019

Merged
merged 1 commit into from
Mar 10, 2017
Merged

when logging exceptions to Sentry, include context #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/workers/feed_eater_schedule_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ def perform(feed_onestop_id, feed_version_sha1, feed_schedule_import_id, trip_id
exception_log = "\n#{e}\n#{e.backtrace}\n"
log exception_log, :error
feed_schedule_import.failed(exception_log: exception_log)
Raven.capture_exception(e) if defined?(Raven)
if defined?(Raven)
Raven.capture_exception(e, {
tags: {
'feed_onestop_id' => feed_onestop_id,
'feed_version_sha1' => feed_version_sha1
}
})
end
else
log "FeedEaterScheduleWorker #{feed_onestop_id}: Saving successful schedule import"
feed_schedule_import.succeeded
Expand Down
9 changes: 8 additions & 1 deletion app/workers/feed_eater_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,14 @@ def perform(feed_onestop_id, feed_version_sha1=nil, import_level=0)
log exception_log, :error
log "FeedEaterWorker #{feed_onestop_id}: Saving failed feed import"
feed_version_import.failed(exception_log: exception_log)
Raven.capture_exception(e) if defined?(Raven)
if defined?(Raven)
Raven.capture_exception(e, {
tags: {
'feed_onestop_id' => feed_onestop_id,
'feed_version_sha1' => feed_version.try(:sha1)
}
})
end
else
# Enqueue FeedEaterScheduleWorker jobs, or save successful import.
if import_level < 2
Expand Down
8 changes: 7 additions & 1 deletion app/workers/feed_fetcher_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ def perform(feed_onestop_id)
# SignalException, and SyntaxError
log e.message, :error
log e.backtrace, :error
Raven.capture_exception(e) if defined?(Raven)
if defined?(Raven)
Raven.capture_exception(e, {
tags: {
'feed_onestop_id' => feed_onestop_id
}
})
end
end
end
end