Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq queue adjustments #1079

Merged
merged 2 commits into from
May 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/workers/changeset_apply_worker.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
class ChangesetApplyWorker
include Sidekiq::Worker
sidekiq_options unique: :until_and_while_executing,
unique_job_expiration: 60 * 60, # 1 hour
log_duplicate_payload: true,
retry: false
sidekiq_options queue: :high,
retry: false,
unique: :until_and_while_executing,
unique_job_expiration: 60 * 60 * 22, # 22 hours
log_duplicate_payload: true

def perform(changeset_id, cachekey)
log "ChangesetApplyWorker: #{changeset_id}"
Expand Down
2 changes: 2 additions & 0 deletions app/workers/conflate_stops_with_osm_worker.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
class ConflateStopsWithOsmWorker
include Sidekiq::Worker
sidekiq_options queue: :default,
retry: false

def perform(stop_ids = [])
Stop.where(id: stop_ids).find_in_batches do |batch_of_stops|
Expand Down
2 changes: 2 additions & 0 deletions app/workers/feed_activation_worker.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
class FeedActivationWorker
include Sidekiq::Worker
sidekiq_options queue: :default,
retry: false

def perform(feed_onestop_id, feed_version_sha1, import_level)
log "FeedActivationWorker #{feed_onestop_id}: activating #{feed_version_sha1} at import_level #{import_level}"
Expand Down
2 changes: 2 additions & 0 deletions app/workers/feed_deactivation_worker.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
class FeedDeactivationWorker
include Sidekiq::Worker
sidekiq_options queue: :default,
retry: false

def perform(feed_onestop_id, feed_version_sha1)
log "FeedDeactivationWorker #{feed_onestop_id}: deactivating #{feed_version_sha1}"
Expand Down
4 changes: 2 additions & 2 deletions app/workers/feed_eater_schedule_worker.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class FeedEaterScheduleWorker
include Sidekiq::Worker

sidekiq_options queue: :feed_eater_schedule, retry: false
sidekiq_options queue: :feed_eater_schedule,
retry: false

def perform(feed_onestop_id, feed_version_sha1, feed_schedule_import_id, trip_ids, agency_map, route_map, stop_map, rsp_map)
log "FeedEaterScheduleWorker #{feed_onestop_id}: Importing #{trip_ids.size} trips"
Expand Down
11 changes: 5 additions & 6 deletions app/workers/feed_eater_worker.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
class FeedEaterWorker
include Sidekiq::Worker

sidekiq_options unique: :until_and_while_executing,
unique_job_expiration: 60 * 60, # 1 hour
log_duplicate_payload: true,
queue: :feed_eater,
retry: false
sidekiq_options queue: :feed_eater,
retry: false,
unique: :until_and_while_executing,
unique_job_expiration: 60 * 60 * 22, # 22 hours
log_duplicate_payload: true

def perform(feed_onestop_id, feed_version_sha1=nil, import_level=0)
feed = Feed.find_by!(onestop_id: feed_onestop_id)
Expand Down
8 changes: 5 additions & 3 deletions app/workers/feed_fetcher_worker.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
class FeedFetcherWorker
include Sidekiq::Worker

sidekiq_options unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60 # 22 hours
sidekiq_options queue: :default,
retry: false,
unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60, # 22 hours
log_duplicate_payload: true

def perform(feed_onestop_id)
begin
Expand Down
3 changes: 2 additions & 1 deletion app/workers/feed_info_worker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

class FeedInfoWorker
include Sidekiq::Worker
sidekiq_options :retry => false
sidekiq_options queue: :high,
retry: false

def perform(url, cachekey)
@url = url
Expand Down
8 changes: 5 additions & 3 deletions app/workers/gtfs_statistics_worker.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
class GTFSStatisticsWorker
include Sidekiq::Worker

sidekiq_options unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60 # 22 hours
sidekiq_options queue: :low,
retry: false,
unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60, # 22 hours
log_duplicate_payload: true

def perform(feed_version_sha1)
feed_version = FeedVersion.find_by!(sha1: feed_version_sha1)
Expand Down
8 changes: 5 additions & 3 deletions app/workers/gtfs_validation_worker.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
class GTFSValidationWorker
include Sidekiq::Worker

sidekiq_options unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60 # 22 hours
sidekiq_options queue: :low,
retry: false,
unique: :until_and_while_executing,
unique_job_expiration: 22 * 60 * 60, # 22 hours
log_duplicate_payload: true

def perform(feed_version_sha1)
feed_version = FeedVersion.find_by!(sha1: feed_version_sha1)
Expand Down
4 changes: 3 additions & 1 deletion config/sidekiq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ production:
:process_limits:
feed_eater_schedule: 1
:queues:
- high
- default
- feed_eater
- feed_eater_schedule
- default
- low