Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging initializer and gtfs_graph log function #615

Merged
merged 2 commits into from
Jun 9, 2016

Conversation

doublestranded
Copy link
Contributor

Moving GTFSGraph log method into initializer for common use. This ensures both Rails and Sidekiq logging are done when appropriate.

@drewda
Copy link
Member

drewda commented Jun 9, 2016

@doublestranded your initializer looks good. One suggestion I do have is to expose the logger object, rather than just pass calls through to the info method. That would allow you to log at different levels (info, debug, warn) throughout the code. Easiest way to do this might be with alias_method: http://apidock.com/ruby/Module/alias_method

@doublestranded doublestranded merged commit 56d43ed into master Jun 9, 2016
@doublestranded doublestranded deleted the logging-initializer branch June 9, 2016 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants