Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against nil geometry returned by convex_hull #966

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

irees
Copy link
Member

@irees irees commented Feb 14, 2017

This can happen RGeo::Feature.cast when the two geometries have incompatible coordinates, e.g. different hemisphere.

Partial fix for https://github.com/transitland/transitland/issues/56

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@07ea850). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #966   +/-   ##
========================================
  Coverage          ?   90.9%           
========================================
  Files             ?      99           
  Lines             ?    3839           
  Branches          ?       0           
========================================
  Hits              ?    3490           
  Misses            ?     349           
  Partials          ?       0
Impacted Files Coverage Δ
app/services/gtfs_graph.rb 87.79% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ea850...1233ef0. Read the comment docs.

@doublestranded doublestranded merged commit 8e5258c into master Feb 14, 2017
@doublestranded doublestranded deleted the operator-convex-hull-nil-guard branch February 14, 2017 00:28
@irees irees mentioned this pull request Feb 16, 2017
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants