More new UI picks and adjustments #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of the messages shown below the roleup and above the translate actions. That data is meant to be shown in the roleup.
These changes are meant to get us closer to Evernote, and reduce conflicts.
Pick notes: Had to do heavy adjustments since we serve part of the data using
JavaScript, and our overview view is very different than Evernote's.
Conflicts:
pootle/apps/pootle_translationproject/views.py
pootle/core/helpers.py
|
GTM |
The following exception was being thrown: 'TranslationProject' object has no attribute 'is_dir'. Not sure why the `request.ctx_obj` (I even tried `request.resource_obj`) in `get_overview_context` is not working, because it should.
Pick notes: This is picking the rest of the commit that we didn't have.
julen
pushed a commit
to julen/pootle
that referenced
this pull request
Jun 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are only a few commits, but lets try to merge them before we get into other more deep changes that might not work. Also these ones improve the UI.