Cleanup: remove unused utils #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
force-pushed
the
cleanup
branch
4 times, most recently
from
1778996
to
622dcc7
Compare
|
Thank you @phlax, these look good to me, and it's nice to see them go! Before merging the commit removing the lock though I'd prefer to have at least a couple pair of eyes check and test that. Note there's also the |
|
yep - ill remove - and also add a WIP header to this PR - i should have done so already |
phlax
changed the title
|
@julen if you had 10 mins for a gitter chat that would be really handy |
phlax
force-pushed
the
cleanup
branch
4 times, most recently
from
245d64d
to
1820cb1
Compare
phlax
changed the title
|
Note the |
phlax
changed the title
|
Did a quick test. GTM with the revert the @julen raised above. |
phlax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these functions dont appear to be used anywhere
in order to find these i have looked through the untested lines on coveralls, found functions and methods that are not used at all, and then grepped the code to ascertain if they are being used and just not being tested.
afaict all of these are unused.
there may be some mistakes or i may have misunderstood how some things work - apologies in advance if that is the case.