Vfolders namespace #5221
Merged
Vfolders namespace #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
force-pushed
the
vfolders_namespace
branch
from
04ce8c1
to
9186ef0
Compare
| # or later license. See the LICENSE file for a copy of the license and the | ||
| # AUTHORS file for copyright and authorship information. | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: only one blank line before imports.
phlax
force-pushed
the
vfolders_namespace
branch
4 times, most recently
from
edc79fa
to
f3e344f
Compare
| def test_views_vf_translate(vfolder_views, settings): | ||
| from tp import _test_browse_view, _test_translate_view | ||
| test_type, tp, request, response, kwargs = vfolder_views | ||
| if test_type == "browse": |
phlax
force-pushed
the
vfolders_namespace
branch
17 times, most recently
from
449c003
to
86388e5
Compare
| # A clean pootle path is a pootle path without any virtual folder name on | ||
| # it. For example /af/test_vfolders/browser/chrome/ is the corresponding | ||
| # clean pootle path for /af/test_vfolders/browser/vfolder8/chrome/ | ||
| vfolder, clean_pootle_path = extract_vfolder_from_path(pootle_path) |
There was a problem hiding this comment.
Given that this is dropped you can probably further simplify the surrounding code a bit more now that clean_pootle_path and pootle_path are the same.
phlax
force-pushed
the
vfolders_namespace
branch
3 times, most recently
from
21a01cd
to
fea850a
Compare
| if filename: | ||
| pootle_path = pootle_path + filename | ||
| clean_pootle_path = clean_pootle_path + filename | ||
| pootle_path = pootle_path + filename |
phlax
force-pushed
the
vfolders_namespace
branch
2 times, most recently
from
fa2e6cb
to
02bc9b0
Compare
phlax
force-pushed
the
vfolders_namespace
branch
from
02bc9b0
to
e142ed1
Compare
|
lgtm |
|
massive thanks for all your hard working reviewing and explaining our bugs back to us @unho ! |
This was referenced Sep 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses concerns raised in #5217 (Namespacing problems with virtualfolders)