Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone/move/remove project commands #5940

Open
wants to merge 507 commits into
base: feature/project_command
Choose a base branch
from

Conversation

ta2-1
Copy link
Contributor

@ta2-1 ta2-1 commented Feb 1, 2017

No description provided.

for check in false_positive_checks:
QualityCheck.objects.filter(
unit__store=target_store,
unit__unitid_hash=check['unit__unitid_hash'],
Copy link
Member

@phlax phlax Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could probs optimize this a bit with

unit__unitid_hash__in=hashes,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not actually

Copy link
Member

@phlax phlax Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would work

qs = QualityCheck.objects.none()
for check in false_positive_checks:
     qs = qs | QualityCheck.objects.filter(...check_filters...)
qs.update(false_positive=True)

@ta2-1 ta2-1 force-pushed the project-commands branch 10 times, most recently from a2e513c to ae9e1ca Compare February 10, 2017 15:28
@ta2-1 ta2-1 force-pushed the project-commands branch 3 times, most recently from cf9ef1b to caecdb1 Compare February 13, 2017 09:34
@ta2-1 ta2-1 changed the title [WIP] Add clone/move/remove project commands Add clone/move/remove project commands Feb 13, 2017
@ta2-1 ta2-1 force-pushed the project-commands branch 3 times, most recently from 82647f3 to cf9805a Compare February 13, 2017 19:41
claudep and others added 29 commits April 8, 2017 16:41
Those are aliases, but force_text is compatible with Python 3.
- allow TP updating from TP from another project
- Raise error if project directory exists on disk
- Add support to move TPs to existing project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants