Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Handle missing babel locale again #5965

Merged
merged 2 commits into from
Feb 13, 2017
Merged

i18n: Handle missing babel locale again #5965

merged 2 commits into from
Feb 13, 2017

Commits on Feb 13, 2017

  1. Refactor: Use public name to allow reuse

    @unho
    unho committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    9f0bece View commit details
    Browse the repository at this point in the history

  2. i18n: Handle missing babel locale on timesince formatting 

    LocalDate is dropped since the right babel locale formatter can
be already retrieved by using the more reliable get_locale_formats
function which provides sane defaults to fall back to in case of
locale being missing in babel.

The leftover code after this refactoring is simple enough to be folded
into the timesince function. Also did minor refactor to get_locale_formats
in order to allow telling to retrieve a specific locale, which eases
testing specific locales formatting.

Fixes: 'UnknownLocaleError: unknown locale 'son'
    @unho
    unho committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    898316d View commit details
    Browse the repository at this point in the history