Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: unbind user from StoreScoreUpdater #6122

Merged
merged 1 commit into from
Mar 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pootle/apps/pootle_score/updater.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ class StoreScoreUpdater(object):

def __init__(self, store, *args, **kwargs):
self.store = store
self.user = kwargs['user']
self.user = kwargs.get('user')
6 changes: 4 additions & 2 deletions tests/pootle_score/updater.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@

@pytest.mark.django_db
def test_score_store_updater(store0, admin):
updater = score_data_updater.get(Store)(store=store0, user=admin)
updater = score_data_updater.get(Store)(store=store0)
assert updater.store == store0
assert updater.user == admin
assert updater.user is None
assert isinstance(updater, StoreScoreUpdater)
updater = score_data_updater.get(Store)(store=store0, user=admin)
assert updater.user == admin