Move subcommand to dj.subcommand #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make stylelint happy
unho
reviewed
Nov 27, 2017
|
|
||
| class SubcommandsError(subcommand.subcommands.SubcommandsError): |
There was a problem hiding this comment.
Do we need to define here a exception that has been defined in third party package?
There was a problem hiding this comment.
i did this to avoid code changes elsewhere, but maybe it wasnt necessary - ill check
|
lgtm after nit, provided Travis passes. |
phlax
force-pushed
the
move_subcommand
branch
from
d66006d
to
d16a5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have separated and released the subcommand functionality here http://github.com/phlax/dj.subcommand
This PR uses that module instead of hosting the code in pootle. This will reduce code, make tests quicker etc. This makes sense as the code rarely changes, and is not specific to pootle.
There is a fix in the upstream code already.