Requested Changes for current release #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplified retry mechanism, therefore: -- counting logic was placed in qualifiedForRetry() -- a new method timeoutBeforeRetry(), which performs the wait before the retry, was implemented Requested additional changes are: - custom timout times,handled by the Transloadit.class - renamed the getAssemblyID method. Additional changes: jUnit Tests for all new methods
Acconut
reviewed
Oct 23, 2021
| * @param timeout in ms | ||
| * @throws LocalOperationException if provided timeout is smaller than 0 | ||
| */ | ||
| public void setTimeoutRetry(int timeout) throws LocalOperationException { |
There was a problem hiding this comment.
I think the terminology is a bit off here. A timeout is a time period after with an operation is cancelled if it hasn't finished before the period's end. The term retry delay is probably better suited since it is the period we are waiting between retry attempts. Does that make sense? Apologies if this causes you to rename all the methods again.
There was a problem hiding this comment.
I'll go over that right now
Acconut
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made requested changes on the current release:
-- counting logic was placed in qualifiedForRetry()
-- a new method timeoutBeforeRetry(), which performs the wait before the retry, was implemented
Requested additional changes are:
Additional changes:
jUnit Tests for all new methods