@uppy/xhr-upload: upload fails if server returns 204 empty

[pzeinlinger]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

1. init xhr plugin

uppy.use(XHR, {
      endpoint: xhrEndpoint,
      fieldName: "file",
      formData: true,
      limit: 5,
})

2. upload file and return 204 from server

Expected behavior

Upload should succeed

Actual behavior

Uncaught SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
    getResponseData index.js:68

Client behaves different from documented behaviour (https://uppy.io/docs/xhr-upload/#getresponsedata, default: (responseText, response) => void).
Change been introduced in #4892.
Issue is at:

uppy/packages/@uppy/xhr-upload/src/index.ts

Line 120 in 1fe7297

return JSON.parse(responseText)