Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Link" is not translated (Url module) #5017

Closed
2 tasks done
romain130492 opened this issue Mar 25, 2024 · 2 comments
Closed
2 tasks done

"Link" is not translated (Url module) #5017

romain130492 opened this issue Mar 25, 2024 · 2 comments
Labels

Comments

@romain130492
Copy link

romain130492 commented Mar 25, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Open the Uppy panel with the Url module set-up. Its not translated into other languages.

Screenshot 2024-03-25 at 12 02 23

Expected behavior

Like with other module, it should be translated into other language when updating the i18n language. Or we should have the option to add update it manually like this

 locale: {
              ...currentLocale,
              strings: {
                browseFiles: t('browse files'),
            // url, Url, Link, link: I tried all of them and it doesnt do anything
              },
            },

### Actual behavior

- i18n is not working for that particular word "Link"

Thanks!
@Murderlon
Copy link
Member

For now you can pass title to the options of the plugin. This is a bit inconsistent, some plugins do this via locale, others via options. I'm making an issue to align this.

@Murderlon Murderlon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@romain130492
Copy link
Author

amazing, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants