-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@uppy/form crashes browser on v3.1.0 and higher #5057
Comments
Hi, you've enabled both Is there a use case you have for both? Otherwise I'll make a PR to |
@Murderlon Thanks for the quick response. I've both options set because I would like to trigger the upload on submit and I want the form to be submitted once the upload has been completed. I think I misunderstand the |
@Murderlon Hm, I've |
You're right I overlooked something. In that case we just need a check whether the upload already happened. |
Initial checklist
Link to runnable example
https://p2l39x.csb.app/
Steps to reproduce
I can reproduce this behavior in Chrome v123, Edge v123 and Firefox v124 at Windows 11 23H2.
Expected behavior
The browser window should not crash and the form should be submitted with the relevant metadata in it.
Actual behavior
The browser window crashes and after some research I discovered it was related to the Form-plugin. The last working version of the plugin is v3.0.3, all versions after that contain this bug. One time I was able to create a trace with the Chrome profiler (I wasn't able to do this another time, because when the browser window crashes, the profiler seems to crash at well).
The problematic code seems to be the function addResultsToForm (at least it consumes a serious amount of CPU-time) . This code has been refactored to Typescript since v3.1.0, so I think there went something wrong during the refactoring of this code.
The text was updated successfully, but these errors were encountered: