Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite all Companion validation errors to respond with a status code and message #5108

Closed
2 tasks done
mifi opened this issue Apr 22, 2024 · 3 comments
Closed
2 tasks done
Labels

Comments

@mifi
Copy link
Contributor

mifi commented Apr 22, 2024

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

When a

for example if COMPANION_AWS_BUCKET is not set, but someone tries to use Uppy S3 plugin against Companion, it will cause an error in the log file, which might trigger a false alarm in ops:

[error] c48cc354 uploader.error TypeError: s3: bucket key must be a string or a function resolving the bucket string

Solution

It was suggested that we should instead respond to the HTTP request with a status code (4xx?) with a message (and not log it as a TypeError)

Alternatives

leave it as is

Kind of related #4762 #4079

@mifi mifi added the Feature label Apr 22, 2024
@nayelimdejesus
Copy link

I would like to be assigned to this issue.

@mifi
Copy link
Contributor Author

mifi commented Aug 16, 2024

Hi. feel free to outline your suggested solution and we can discuss it

@mifi
Copy link
Contributor Author

mifi commented Aug 29, 2024

closing in favor of #5436

@mifi mifi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants