Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done button shows when doneButtonHandler is null #5282

Closed
2 tasks done
yellowtailfan opened this issue Jun 27, 2024 · 0 comments · Fixed by #5283
Closed
2 tasks done

Done button shows when doneButtonHandler is null #5282

yellowtailfan opened this issue Jun 27, 2024 · 0 comments · Fixed by #5283
Labels

Comments

@yellowtailfan
Copy link

yellowtailfan commented Jun 27, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  1. Add an Uppy Dashboard component in React with doneButtonHandler={null}
              <Dashboard
                uppy={uppy}
                showLinkToFileUploadResult={false}
                showProgressDetails={true}
                doneButtonHandler={null}
                proudlyDisplayPoweredByUppy={false}
                disableThumbnailGenerator={true}
                width={'100%'}
                height={'40vh'}
              />
  1. Drag in 5 files and click Upload
  2. Wait for upload to complete

Expected behavior

Expected Done button not to appear. This was the behaviour with a previous version of Uppy.

Actual behavior

A Done button is shown. I am using the latest release of Uppy:

    "@uppy/aws-s3": "^3.6.2",
    "@uppy/core": "^3.13.0",
    "@uppy/dashboard": "^3.9.0",
    "@uppy/drag-drop": "^3.1.0",
    "@uppy/file-input": "^3.1.2",
    "@uppy/progress-bar": "^3.1.1",
    "@uppy/react": "^3.4.0",
    "@uppy/status-bar": "^3.3.3",
    "@uppy/url": "^3.6.1",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant