Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "attempted to use private field on non-instance" #3201

Merged
merged 2 commits into from Sep 20, 2021

Conversation

tykarol
Copy link
Contributor

@tykarol tykarol commented Sep 17, 2021

Copied the same code changes as in theProviderView.js.

This change fixes the "attempted to use private field on non-instance" error message and also fixes the isDisabled issue.

Copy link
Contributor

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! lgtm

@tykarol
Copy link
Contributor Author

tykarol commented Sep 18, 2021

@mifi I fixed the lint error

@Murderlon
Copy link
Member

This is also fixed in my earlier PR #3196, but as that one is big and will take a bit longer, this can be merged already. Thanks for the contribution.

@Murderlon Murderlon merged commit e6b4746 into transloadit:main Sep 20, 2021
Murderlon added a commit that referenced this pull request Sep 20, 2021
* main:
  Show all details on mobile when `showProgressDetails` is `true` (#3174)
  @uppt/xhr-upload: fix `this.uppy is undefined` error (#3207)
  ci: test on Node.js v16.x (#3205)
  @uppy/dashboard: fix linter (#3206)
  Add `2.1.1` to `CHANGELOG.md`
  Release
  Release
  Fix "attempted to use private field on non-instance" in `SearchProvider` (#3201)
  Add 'done' to `nb_NO.js` (#3200)
  @uppy/transloadit: fix unhandledPromiseRejection failures (#3197)
  fix: AbortController is not defined on Node.js (Server Side Render) (#3169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchProviderView incorrectly marks all files as disabled Unsplash: All photos are disabled
3 participants