Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-s3-multipart: make
headers
part indexed too inprepareUploadParts
#3895aws-s3-multipart: make
headers
part indexed too inprepareUploadParts
#3895Changes from all commits
bf3e8cc
968346e
d9e3ce6
906efc7
b8bc31d
d8cc17b
b37dcf8
9af6d5d
ed4abe5
7c92abc
dc9e7c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has there been consideration for using
partNumber
in place ofnumber
? So it would read asArray<{ partNumber: number, chunk: blob }>
instead.It might just be me, but reading
{ number: number }
kind of trips one up a little bit at first glance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I prefer making keys intention revealing with the context of the parent object.
part.number
already implies it's the part's number, wherespart.partNumber
sounds like a pleonasm to me.