Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dashboard acquirers list #4306

Merged
merged 2 commits into from Feb 11, 2023
Merged

fix dashboard acquirers list #4306

merged 2 commits into from Feb 11, 2023

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Feb 7, 2023

  • fix broken grouping and tagline logic (didn't take into account all acquirers like showNativePhotoCameraButton)
  • don't show lonely My Device

https://community.transloadit.com/t/hide-my-device/16456

- fix broken grouping and tagline logic (didn't take into account all acquirers like showNativePhotoCameraButton)
- don't show lonely My Device

https://community.transloadit.com/t/hide-my-device/16456
@mifi mifi requested a review from arturi February 7, 2023 10:01
@arturi
Copy link
Contributor

arturi commented Feb 11, 2023

Thank you! This indeed improves the logic, as for the lonely MyDevice, I must have broken it when adding mobile native photo / video buttons. Tested locally, works as advertised!

Screen Shot 2023-02-11 at 15 20 10

@arturi arturi merged commit 04cdb61 into main Feb 11, 2023
@arturi arturi deleted the dashboard-acquirers branch February 11, 2023 15:21
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
github-actions bot added a commit that referenced this pull request Feb 13, 2023
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/audio          |   1.0.4 | @uppy/screen-capture |   3.0.2 |
| @uppy/companion      |   4.3.0 | @uppy/transloadit    |   3.1.1 |
| @uppy/core           |   3.0.6 | @uppy/xhr-upload     |   3.1.0 |
| @uppy/dashboard      |   3.2.2 | uppy                 |   3.5.0 |
| @uppy/locales        |   3.0.6 |                      |         |

- @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / #4316)
- meta: Remove Robodog advice, since it is deprecated (Artur Paikin)
- @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / #4306)
- @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / #4292)
- @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / #4302)
- @uppy/locales: Update de_DE.js (Jörn Velten / #4297)
- meta: use load balancer for companion in e2e tests (Mikael Finstad / #4228)
- @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / #4286)
- @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / #4247)
- @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / #4282)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/audio          |   1.0.4 | @uppy/screen-capture |   3.0.2 |
| @uppy/companion      |   4.3.0 | @uppy/transloadit    |   3.1.1 |
| @uppy/core           |   3.0.6 | @uppy/xhr-upload     |   3.1.0 |
| @uppy/dashboard      |   3.2.2 | uppy                 |   3.5.0 |
| @uppy/locales        |   3.0.6 |                      |         |

- @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / transloadit#4316)
- meta: Remove Robodog advice, since it is deprecated (Artur Paikin)
- @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / transloadit#4306)
- @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / transloadit#4292)
- @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / transloadit#4302)
- @uppy/locales: Update de_DE.js (Jörn Velten / transloadit#4297)
- meta: use load balancer for companion in e2e tests (Mikael Finstad / transloadit#4228)
- @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / transloadit#4286)
- @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / transloadit#4247)
- @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / transloadit#4282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants