don't cancel all files when clicking "done"

[mifi]

calling cancelAll also causes any active assembly to be cancelled (when waitForEncoding: false). Doesn't make sense to me that assembly should be cancelled when a user clicks the "Done" button after an upload has completed. Also it doesn't make sense to cancel uploads when clicking "done"

The button was introduced in #2653

[arturi]

When Dashboard is using with an inline mode, we can't just hide modal when “done” is pressed — the state will stay the same. And even in modal, after it’s called back, the “complete” or “error” state will still be there. I’ve pushed a commit to reset state to default, but we should actually implement an uppy.reset() method in Core, as I’ve suggested before.

[Murderlon]

Note that this is practically identical to resetProgress with the only difference that files aren't removed. Should indeed be streamlined.

uppy/packages/@uppy/core/src/Uppy.js

Lines 233 to 261 in 12e08ad

	resetProgress () {
	const defaultProgress = {
	percentage: 0,
	bytesUploaded: 0,
	uploadComplete: false,
	uploadStarted: null,
	}
	const files = { ...this.getState().files }
	const updatedFiles = {}
	Object.keys(files).forEach(fileID => {
	updatedFiles[fileID] = {
	...files[fileID],
	progress: {
	...files[fileID].progress, ...defaultProgress,
	},
	}
	})
	this.setState({
	files: updatedFiles,
	totalProgress: 0,
	allowNewUpload: true,
	error: null,
	recoveredState: null,
	})
	this.emit('reset-progress')
	}

[mifi]

yes i also suggested that during the call, but the reasoning was that it's very slow because it iterates over all files. but in this case we don't need to do that because all files will be removed anyways. but yea we should probably reuse parts of that function

[mifi]

pushed some code reuse

[abdirahmn1]

To anyone having a problem with this bug at the moment., use the following workaround till this becomes available. Set waitForEncoding: true on Transloadit options.

const uppy = new Uppy(<uppy_options>).use(TransloadIt, {
    assemblyOptions: {
      params: {
        auth: { key: "your transloadit key"},
        template_id: "your transloadit template id",
      },
    },
    waitForEncoding: true,
  });

The done button that would cancel the assembly would not appear until the assembly is completed.