Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash if trying to set path to / #5003

Merged
merged 2 commits into from
Mar 19, 2024
Merged

crash if trying to set path to / #5003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19400c3
crash if trying to set path to /
mifi Mar 17, 2024
e41a1d8
Update packages/@uppy/companion/src/config/companion.js
mifi Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/@uppy/companion/src/config/companion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,13 @@ const validateConfig = (companionOptions) => {
)
}

const { providerOptions, periodicPingUrls } = companionOptions
const { providerOptions, periodicPingUrls, server } = companionOptions

if (server && server.path) {
// see https://github.com/transloadit/uppy/issues/4271
// todo fix the code so we can allow `/`
if (server.path === '/') throw new Error('server.path cannot be set to /')
mifi marked this conversation as resolved.
Show resolved Hide resolved
}

if (providerOptions) {
const deprecatedOptions = { microsoft: 'providerOptions.onedrive', google: 'providerOptions.drive', s3: 's3' }
Expand Down