Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequential download in torrent properties #1225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sequential download in torrent properties #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion main.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3866,7 +3866,7 @@ procedure TMainForm.TorrentProps(PageNo: integer);
gTorrents.EnsureSelectionVisible;
TorrentIds:=GetSelectedTorrents;
args:=RpcObj.RequestInfo(id, ['downloadLimit', 'downloadLimitMode', 'downloadLimited', 'uploadLimit', 'uploadLimitMode', 'uploadLimited',
'name', 'maxConnectedPeers', 'seedRatioMode', 'seedRatioLimit', 'seedIdleLimit', 'seedIdleMode', 'trackers']);
'name', 'maxConnectedPeers', 'seedRatioMode', 'seedRatioLimit', 'seedIdleLimit', 'seedIdleMode', 'trackers', 'sequential']);
if args = nil then begin
CheckStatus(False);
exit;
Expand Down Expand Up @@ -3954,6 +3954,12 @@ procedure TMainForm.TorrentProps(PageNo: integer);
tabAdvanced.TabVisible:=False;
end;
edPeerLimit.Value:=t.Integers['maxConnectedPeers'];
try
cbSequential.Checked:=t.Booleans['sequential'];
except
cbSequential.Enabled:=false;
cbSequential.Hint:='Your transmission is not supported';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cbSequential.Hint:='Your transmission is not supported';
cbSequential.Hint:='Sequential download is not supported by your Transmission version.';

end;
finally
args.Free;
end;
Expand All @@ -3973,6 +3979,9 @@ procedure TMainForm.TorrentProps(PageNo: integer);
ids.Add(integer(TorrentIds[i]));
args.Add('ids', ids);

if cbSequential.Enabled=true then
args.Add('sequential', integer(cbSequential.Checked) and 1);

if RpcObj.RPCVersion < 5 then
begin
// RPC versions prior to v5
Expand Down
100 changes: 55 additions & 45 deletions torrprops.lfm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
inherited TorrPropsForm: TTorrPropsForm
Left = 364
Height = 270
Height = 314
Top = 185
Width = 517
HorzScrollBar.Page = 349
Expand All @@ -11,16 +11,16 @@ inherited TorrPropsForm: TTorrPropsForm
BorderIcons = [biSystemMenu]
BorderStyle = bsDialog
Caption = 'Torrent properties'
ClientHeight = 270
ClientHeight = 314
ClientWidth = 517
Constraints.MinHeight = 186
Constraints.MinWidth = 350
OnCreate = FormCreate
Position = poMainFormCenter
object Buttons: TButtonPanel[0]
Left = 8
Height = 26
Top = 236
Height = 22
Top = 284
Width = 501
BorderSpacing.Left = 8
BorderSpacing.Right = 8
Expand All @@ -41,7 +41,7 @@ inherited TorrPropsForm: TTorrPropsForm
end
object Page: TPageControl[1]
Left = 8
Height = 220
Height = 268
Top = 8
Width = 501
ActivePage = tabGeneral
Expand All @@ -51,64 +51,64 @@ inherited TorrPropsForm: TTorrPropsForm
TabOrder = 0
object tabGeneral: TTabSheet
Caption = 'General'
ClientHeight = 194
ClientWidth = 493
ClientHeight = 229
ClientWidth = 495
object txKbs1: TLabel
Left = 420
Height = 14
Left = 415
Height = 16
Top = 37
Width = 22
Width = 29
Anchors = [akTop, akRight]
Caption = 'KB/s'
ParentColor = False
end
object txKbs2: TLabel
Left = 420
Height = 14
Left = 415
Height = 16
Top = 69
Width = 22
Width = 29
Anchors = [akTop, akRight]
Caption = 'KB/s'
ParentColor = False
end
object txName: TLabel
Left = 10
Height = 14
Height = 16
Top = 10
Width = 32
Width = 40
Caption = 'Name:'
ParentColor = False
ShowAccelChar = False
end
object txPeerLimit: TLabel
Left = 10
Height = 14
Top = 101
Width = 48
Height = 16
Top = 131
Width = 63
Caption = 'Peer limit:'
ParentColor = False
end
object txMinutes: TLabel
Left = 420
Height = 14
Top = 163
Width = 38
Left = 409
Height = 16
Top = 193
Width = 51
Anchors = [akTop, akRight]
Caption = 'minutes'
ParentColor = False
end
object cbMaxDown: TCheckBox
Left = 10
Height = 17
Height = 18
Top = 36
Width = 147
Width = 185
Caption = 'Maximum download speed:'
OnClick = cbMaxDownClick
TabOrder = 0
end
object edMaxDown: TSpinEdit
Left = 340
Height = 21
Left = 342
Height = 16
Top = 34
Width = 66
Anchors = [akTop, akRight]
Expand All @@ -118,16 +118,16 @@ inherited TorrPropsForm: TTorrPropsForm
end
object cbMaxUp: TCheckBox
Left = 10
Height = 17
Height = 18
Top = 68
Width = 133
Width = 168
Caption = 'Maximum upload speed:'
OnClick = cbMaxUpClick
TabOrder = 2
end
object edMaxUp: TSpinEdit
Left = 340
Height = 21
Left = 342
Height = 16
Top = 66
Width = 66
Anchors = [akTop, akRight]
Expand All @@ -136,9 +136,9 @@ inherited TorrPropsForm: TTorrPropsForm
TabOrder = 3
end
object edPeerLimit: TSpinEdit
Left = 340
Height = 21
Top = 98
Left = 342
Height = 16
Top = 128
Width = 66
Anchors = [akTop, akRight]
MaxValue = 999
Expand All @@ -148,18 +148,18 @@ inherited TorrPropsForm: TTorrPropsForm
end
object cbSeedRatio: TCheckBox
Left = 10
Height = 17
Top = 131
Width = 71
Height = 18
Top = 161
Width = 86
AllowGrayed = True
Caption = 'Seed ratio:'
OnClick = cbSeedRatioClick
TabOrder = 5
end
object edSeedRatio: TFloatSpinEdit
Left = 340
Height = 21
Top = 129
Left = 342
Height = 16
Top = 159
Width = 66
Anchors = [akTop, akRight]
Increment = 0.1
Expand All @@ -170,25 +170,35 @@ inherited TorrPropsForm: TTorrPropsForm
end
object cbIdleSeedLimit: TCheckBox
Left = 10
Height = 17
Top = 162
Width = 170
Height = 18
Top = 192
Width = 211
AllowGrayed = True
Caption = 'Stop seeding when inactive for:'
OnClick = cbIdleSeedLimitClick
TabOrder = 7
end
object edIdleSeedLimit: TSpinEdit
Left = 340
Height = 21
Top = 160
Left = 342
Height = 16
Top = 190
Width = 66
Anchors = [akTop, akRight]
MaxValue = 999999
MinValue = 1
TabOrder = 8
Value = 1
end
object cbSequential: TCheckBox
Left = 10
Height = 18
Top = 100
Width = 147
Caption = 'Sequential download'
TabOrder = 9
ParentShowHint = False
ShowHint = True
end
end
object tabAdvanced: TTabSheet
Caption = 'Advanced'
Expand Down
1 change: 1 addition & 0 deletions torrprops.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ TTorrPropsForm = class(TBaseForm)
cbMaxDown: TCheckBox;
cbMaxUp: TCheckBox;
cbSeedRatio: TCheckBox;
cbSequential: TCheckBox;
edIdleSeedLimit: TSpinEdit;
edMaxUp: TSpinEdit;
edPeerLimit: TSpinEdit;
Expand Down