refactor: remove obsolete lightweight build option

transmission · Jan 1, 2023 · d2ed80d · d2ed80d
1 parent 453836f
commit d2ed80d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -48,7 +48,6 @@ tr_auto_option(ENABLE_MAC           "Build Mac client" AUTO)
         option(ENABLE_UTILS         "Build utils (create, edit, show)" ON)
         option(ENABLE_CLI           "Build command-line client" OFF)
         option(ENABLE_TESTS         "Build unit tests" ON)
-        option(ENABLE_LIGHTWEIGHT   "Optimize libtransmission for low-resource systems: smaller cache size, prefer unencrypted peer connections, etc." OFF)
         option(ENABLE_UTP           "Build µTP support" ON)
         option(ENABLE_WERROR        "Treat warnings as errors" OFF)
         option(ENABLE_NLS           "Enable native language support" ON)

diff --git a/libtransmission/CMakeLists.txt b/libtransmission/CMakeLists.txt
@@ -216,10 +216,6 @@ add_definitions(
     ${MINIUPNPC_DEFINITIONS}
 )
 
-if(ENABLE_LIGHTWEIGHT)
-    add_definitions(-DTR_LIGHTWEIGHT)
-endif()
-
 if(NOT ENABLE_NLS)
     add_definitions(-DDISABLE_GETTEXT)
 endif()

diff --git a/libtransmission/crypto-utils-openssl.cc b/libtransmission/crypto-utils-openssl.cc
@@ -37,11 +37,7 @@ static void log_openssl_error(char const* file, int line)
 
     if (tr_logLevelIsActive(TR_LOG_ERROR))
     {
-#ifndef TR_LIGHTWEIGHT
-
-        static bool strings_loaded = false;
-
-        if (!strings_loaded)
+        if (static bool strings_loaded = false; !strings_loaded)
         {
 #if OPENSSL_VERSION_NUMBER < 0x10100000 || (defined(LIBRESSL_VERSION_NUMBER) && LIBRESSL_VERSION_NUMBER < 0x20700000)
             ERR_load_crypto_strings();
@@ -52,8 +48,6 @@ static void log_openssl_error(char const* file, int line)
             strings_loaded = true;
         }
 
-#endif
-
         auto buf = std::array<char, 512>{};
         ERR_error_string_n(error_code, std::data(buf), std::size(buf));
         tr_logAddMessage(

diff --git a/libtransmission/utils.h b/libtransmission/utils.h
@@ -43,7 +43,7 @@ struct tr_error;
 
 /* #define DISABLE_GETTEXT */
 #ifndef DISABLE_GETTEXT
-#if defined(_WIN32) || defined(TR_LIGHTWEIGHT)
+#if defined(_WIN32)
 #define DISABLE_GETTEXT
 #endif
 #endif