Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a .resume file fails on Windows due to the created file having an incomplete name #1009

Closed
AntonPetrochenko opened this issue Sep 25, 2019 · 2 comments

Comments

@AntonPetrochenko
Copy link

AntonPetrochenko commented Sep 25, 2019

Upon adding a torrent with the symbol : in it, the target file name for the .resume for the torrent is abruptly cut off, containing all the letters up to that symbol and even lacking an extension.

Issue walkthrough from observation:

  • Metadata is downloaded properly
  • File created and opened with incomplete name
  • Writing to a file fails
  • Torrent is aborted with an error, all attempts at downloading it and related procedures are ceased
  • Strangely enough, the broken file is never closed and it's impossible to rename or delete it. Referenced by filename, perhaps?
    image
    image
@AntonPetrochenko AntonPetrochenko changed the title Saving a .resume file fails on Windows due to the created file having a corrupted name Saving a .resume file fails on Windows due to the created file having an incomplete name Sep 25, 2019
@AntonPetrochenko
Copy link
Author

AntonPetrochenko commented Sep 25, 2019

Cause:
Atfter some research (that admittedly should have come from the top of the head), the : symbol turned out to be a special symbol in Windows and is not allowed in filenames. A fix would be to escape/replace them, or to stop using filenames that come from arbitrary sources.

@mikedld
Copy link
Member

mikedld commented Oct 13, 2019

See #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants