Error: Unable to save resume file: File name too long

[one-quaker]

If I try add magnet link via transmission-daemon web-interface - I got error "Error: Unable to save resume file: File name too long".
If I add torrent file, all ok.
Deluge torrent client works fine with same magnet link.
I think problem in long name of temporary torrent file, who made from magnet link.

OS: Linux (raspbian arm32), Transmission-2.92 (2.84 have same problem), FS: Ext4

[censored]

Magnet link for test: [censored]

[one-quaker]

How you can reproduce bug if magnet link deleted?

[mikedld]

That's a good question. Suppose the link should've pointed to legal content in the first place...

[cfpp2p]

magnet:?xt=urn:btih:0403fb4728bd788fbcb67e87d6feb241ef38c75a&dn=ubuntu-16.10-desktop-amd64.iso-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long-this-name-is-too-long&tr=http%3A%2F%2Ftorrent.ubuntu.com%3A6969%2Fannounce&tr=http%3A%2F%2Fipv6.torrent.ubuntu.com%3A6969%2Fannounce

[one-quaker]

This magnet link have same problem. Thank you cfpp2p
screenshot

[coffebar]

"Error: Unable to save resume file: File name too long" is a popular problem for me.
I can't download some files with transmission, but with utorrent I can download same files to the same location (via virtual machine with windows and shared folder).

Will be fixed?

[coffebar]

What tool? How to use?
uTorrent saves this file in windows to same location without any problems, why transmission can't?

[one-quaker]

And deluge saves without any problems. Why transmission? - it's a good question

[cfpp2p]

As in my example above (#122 (comment)) you could just text edit manually the name portion of any magnet (begins with &dn=) down to a short(er) length. Or you can patch metainfo.c at maybe get the display name. It's only a temporary display name until the real metadata is acquired.

          /* maybe get the display name */
          if (tr_variantDictFindStr (d, TR_KEY_display_name, &str, &len))
            {
              tr_free (inf->name);
              tr_free (inf->originalName);
              if (len > 50)
                {
                  inf->name = tr_strndup (str, 50);
                  inf->originalName = tr_strndup (str, 50);
                }
              else
                {
                 inf->name = tr_strndup (str, len);
                 inf->originalName = tr_strndup (str, len);
                }
            }

ref: cfpp2p/transmission@bf1d8bb#diff-d54a64807eeb84d2c1ffec36a2dd76c1

[v6]

// , I can confirm I have this, too.

[pik]

Same issue, I don't seem to be able to rename the file on opening a magnet-link (properly this error should prompt for a rename or something of the like?)

[v6]

// , Has anyone tested the work around that @cfpp2p proposed?

[cfpp2p]

@v6 It is and has been working perfectly for me without issue.

[pabloab]

I'm wrong or this bug was here since 2011?

[pik]

I believe this might happen due to use of non-standar encodings such as KOI8R in the torrent name.

[apolukhin]

This issue happens annoyingly often. Are there any plans to fix it?

[v6]

// , Seems like it could potentially be easy enough for someone to fix if they're familiar with the system.

…

On Fri, Jul 7, 2017 at 12:00 PM, Antony Polukhin ***@***.***> wrote: This issue happens annoyingly often. Are there any plans to fix it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#122 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFe_7JjMtT01fzn8i4x-o6DTHFAR44cgks5sLoA_gaJpZM4LQtqo> .

[kov-serg]

I have the same problem today on my Ubuntu 14.04.
I have to find out reason. So get source
mkdir tr && cd tr
apt-get source transmission-gtk
And find error grep 'Unable to save resume file' -R .
Error message is in transmission-2.82/libtransmission/resume.c

  filename = getResumeFilename (tor);
  if ((err = tr_variantToFile (&top, TR_VARIANT_FMT_BENC, filename)))
    tr_torrentSetLocalError (tor, "Unable to save resume file: %s", tr_strerror (err));

It calls getResumeFilename from the same file

static char*
getResumeFilename (const tr_torrent * tor)
{
  char * base = tr_metainfoGetBasename (tr_torrentInfo (tor));
  char * filename = tr_strdup_printf ("%s" TR_PATH_DELIMITER_STR "%s.resume",
                                      tr_getResumeDir (tor->session), base);
  tr_free (base);
  return filename;
}

So the solution is to modify tr_metainfoGetBasename

let modify file transmission-2.82/libtransmission/metainfo.c
from

char*
tr_metainfoGetBasename (const tr_info * inf)
{
  size_t i;
  const char * name = inf->originalName;
  const size_t name_len = strlen (name);
  char * ret = tr_strdup_printf ("%s.%16.16s", name, inf->hashString);

  for (i=0; i<name_len; ++i)
    if (ret[i] == '/')
      ret[i] = '_';

  return ret;
}

to

char*
tr_metainfoGetBasename (const tr_info * inf)
{
  size_t i;
  enum { name_max=32 }; char name[name_max+1];
  const char * full_name;
  size_t name_len;
  char *ret;
  
  full_name = inf->originalName;
  name_len = 0;

  for(i=0;;i++) {
  	char c=full_name[i]; if (!c) { if (i<=name_max) name_len=i; break; }
  	if ((c&0xC0)==0xC0 || ((c&0x80)==0)) { if (i>name_max) break; name_len=i; }
  }
  memcpy(name,full_name,name_len);name[name_len]=0;

  ret = tr_strdup_printf ("%s.%16.16s", name, inf->hashString);

  for (i=0; i<name_len; ++i)
    if (ret[i] == '/')
      ret[i] = '_';

  return ret;
}

I assume utf8 encoding. This limit internal names to 32+17 chars or about. Limit is defined in name_max constant.
then ./configure && make
You can test it running from transmission-2.82/gtk/transmission-gtk
But you have to remove ~/.config/transmission directory or convert names into new scheeme.
Now it downloads any file without problems.

[pabloab]

Hi @kov-serg,
v2.82 of Ubuntu 14.04 is pretty old. Seems you are talking about this lines on master branch. Could you please made a pull request against current source code? Or at least attach a patch file to this issue. Probably this could improve chances of having tested and added to the main source branch.
Thanks!

[kov-serg]

Ununtu 14.04 is work well and I see no reasons to change it on something else.
Here is git diff

diff --git a/libtransmission/metainfo.c b/libtransmission/metainfo.c
index 51b0659..df2b6e7 100644
--- a/libtransmission/metainfo.c
+++ b/libtransmission/metainfo.c
@@ -38,11 +38,24 @@ static inline bool char_is_path_separator(char c)
 
 char* tr_metainfoGetBasename(tr_info const* inf)
 {
-    char const* name = inf->originalName;
-    size_t const name_len = strlen(name);
-    char* ret = tr_strdup_printf("%s.%16.16s", name, inf->hashString);
+    size_t i;
+    enum { name_max=32 }; char name[name_max+1];
+    const char * full_name;
+    size_t name_len;
+    char *ret;
+
+    full_name = inf->originalName;
+    name_len = 0;
+
+    for(i=0;;i++) {
+        char c=full_name[i]; if (!c) { if (i<=name_max) name_len=i; break; }
+        if ((c&0xC0)==0xC0 || ((c&0x80)==0)) { if (i>name_max) break; name_len=i; }
+    }
+    memcpy(name,full_name,name_len);name[name_len]=0;
+
+    ret = tr_strdup_printf ("%s.%16.16s", name, inf->hashString);
 
-    for (size_t i = 0; i < name_len; ++i)
+    for (i = 0; i < name_len; ++i)
     {
         if (char_is_path_separator(ret[i]))
         {

I have no idea how to make pull request without forking
Script to get patch and build transmission from source https://pastebin.com/raw/EWFiuv23
It takes one minute and about 96Mb to build.
Here is link to torrent file that cause the problem ( original http://nnm-club.name/forum/viewtopic.php?p=6130608 copy https://cloud.mail.ru/public/FNV1/zNzh1ncJJ )
It could be used for testing.

ps: Updated build script https://pastebin.com/raw/kGH8UFHi
It takes 37 seconds and 88Mb to build and fetch version with fixed date Jul 22, 2017.

[kov-serg]

here is script to convert old ~/.config/transmission files
In ~/.config/transmission directory
conv.lua

#!/usr/bin/lua

function short_name(fn)
	local function short(s,n)
		local i,j,c
		j=1 i=1 while i<=#s do c=s:byte(i)
			if c<128 or c>=192 then if i-1>n then break end j=i end
			i=i+1
		end
		if i>#s then j=i end
		return s:sub(1,j-1)
	end
	local path,name,hash_ext = fn:match "^(.*/)([^/]*)(%.%x+%.%w+)$"
	if not path then return fn end
	name=short(name,32)
	return path..name..hash_ext
end

function safe(s) return s:gsub('[`"]','\\%1') end

while true do
	local name=io.read() if not name then break end
	local short=short_name(name)
	if name~=short then 
		print('mv "'..safe(name)..'" "'..safe(short)..'"') 
	end
end

find | lua conv.lua > rename-script.sh

and then bash rename-script.sh

[cfpp2p]

We don't need to filter the torrent name for Cyrillic characters or such. The name length should only be limited to 255. This way we won't need to convert .config files. Tested with @kov-serg Zelezko2009.torrent (and others).

#define MAX_NAME_LENGTH 219
// 219 + 36 = 255
// . + 16_byte_hash + .torrent + .tmp.XXXXXX = 36 bytes
// . + 16_byte_hash + .resume + .tmp.XXXXXX = 35 bytes
// see tr_variantToFile() for more explanation

char* tr_metainfoGetBasename(tr_info const* inf)
{
    char const* name = inf->originalName;
    char* shortName;

    if (!strlen(name))
    {
        // allow empty name -- substitute
        shortName = tr_strdup("Hash-Name-");
    }
    else if (strlen(name) <= MAX_NAME_LENGTH)
    {
        shortName = tr_strdup(name);
    }
    else
    {
        // truncate
        shortName = tr_strndup(name, MAX_NAME_LENGTH);
    }

    char* ret = tr_strdup_printf("%s.%16.16s", shortName, inf->hashString);
    size_t const name_len = strlen(shortName);
    tr_free(shortName);

    for (size_t i = 0; i < name_len; ++i)
    {
        if (char_is_path_separator(ret[i]))
        {
            ret[i] = '_';
        }
    }

    return ret;
}

[kov-serg]

Yes you need or it could split unicode symbol that presented with several bytes. Not only cyrilic (кирилица) but also japanise (日本語の文字) characters could be in names especially in anime torrents. So you have to split symbols correctly. For example single character 本 represented by 3 bytes (0xE6,0x9C,0xAC) and if you get only 2 bytes you will have invalid utf8 string. https://pastebin.com/raw/mLzvjtDn ( man 7 utf-8 )

You can set name_max to 219 but I see no reason to have such long names. I use 32 because it looks sufficient in mc.
There is a hash and name could be removed at all. But it could help if you try to find something by hands (but I see no one try). You may create special function to shorten names and convert them into something short but you have create something to migrate from old version to new and backward.

[cfpp2p]

Truncating like this may not display as pretty as it could, but there will only be a single split symbol just before the hash string for the both the .resume file and transmission's internal .torrent copy. Transmission will process these torrents without issue. We don't need to convert because the only torrents truncated are those that wouldn't have saved .torrent or .resume previously because of the file-name too long issue.

[kov-serg]

Why you don't want to split correctly. It will work with transmission but may cause problems in other applications. Do you really want this?

[cfpp2p]

@kov-serg OK with you?, tr_utf8clean(). Set the MAX_NAME_LENGTH as you wish. Please test for your liking.

#define MAX_NAME_LENGTH 219
// 219 + 36 = 255
// . + 16_byte_hash + .torrent + .tmp.XXXXXX = 36 bytes
// . + 16_byte_hash + .resume + .tmp.XXXXXX = 35 bytes
// see tr_variantToFile() for more explanation

char* tr_metainfoGetBasename(tr_info const* inf)
{
    char const* name = inf->originalName;
    char* shortName;
    char* cleanName;

    if (!strlen(name))
    {
        // allow empty name -- substitute
        cleanName = tr_strdup("Hash-Name-");
    }
    else if (strlen(name) <= MAX_NAME_LENGTH)
    {
        cleanName = tr_strdup(name);
    }
    else
    {
        // truncate
        shortName = tr_strndup(name, MAX_NAME_LENGTH);
        cleanName = tr_utf8clean(shortName, -1);
    }
    tr_free(shortName);

    char* ret = tr_strdup_printf("%s.%16.16s", cleanName, inf->hashString);
    size_t const name_len = strlen(cleanName);
    tr_free(cleanName);

    for (size_t i = 0; i < name_len; ++i)
    {
        if (char_is_path_separator(ret[i]))
        {
            ret[i] = '_';
        }
    }

    return ret;
}

[smopucilowski]

Hit this bug last night.

[kov-serg]

What transmission version? And what files in names in config dir
linux: find ~/.config/transmission
windows: dir /s /b "%appdata%/transmission"

[pgorod]

This magnet link fails for me on Windows with version 2.94

magnet:?xt=urn:btih:8ED644946AA19DFB4E4DC58C407B2B0CAA24D82B&dn=%5Bzooqle.com%5D%20Avengers%3A%20Endgame%20%282019%29%20%5BBluRay%5D%20%5B1080p%5D%20%5BYTS.LT%5D&tr=http://explodie.org:6969/announce&tr=http://announce.xxx-tracker.com:2710/announce&tr=https://bigfoot1942.sektori.org/announce&tr=https://bigfoot1942.sektori.org:443/announce&tr=http://open.acgtracker.com:1096/announce&xl=1686660690&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=http%3A%2F%2Fannounce.xxx-tracker.com%3A2710%2Fannounce&tr=http%3A%2F%2Fexplodie.org%3A6969%2Fannounce&tr=https%3A%2F%2Fbigfoot1942.sektori.org%2Fannounce&tr=https%3A%2F%2Fbigfoot1942.sektori.org%3A443%2Fannounce

I guess it's the colon in the name...

I saw a zero-length file in AppData\Local\transmission\Torrents called [zooqle.com] Avengers. The same filename is found in the resume directory, also with 0 bytes.

The error message on the UI said Error: Unable to save resume file: unknown error

I hope this helps debugging. Thanks.

[kov-serg]

It is simple in 2.9x branch no fix applied https://github.com/transmission/transmission/blob/2.9x/libtransmission/metainfo.c or https://github.com/transmission/transmission-releases/raw/master/transmission-2.94.tar.xz
char* tr_metainfoGetBasename (const tr_info * inf) - is unchanged and contains this problem.

Why version with this problem is default for download this is the question.

So you have to use night build. https://build.transmissionbt.com/job/trunk-win32/
There is new version with char* tr_metainfoGetBasename(tr_info const* inf, enum tr_metainfo_basename_format format)

[Queuecumber]

It looks like the 3.0 release will probably never happen, is anyone even maintaining this anymore?

[dausruddin]

@Queuecumber maybe they are busy.
I compiled the program by myself and included some PR.
Currently it is running well excep that I have to use Web-UI from 2.94 because Web-Ui from 3.00 due to bugs.

At this point I would probably migrate to qBittorrent.

[gomera]

@Queuecumber maybe they are busy.
I compiled the program by myself and included some PR.
Currently it is running well excep that I have to use Web-UI from 2.94 because Web-Ui from 3.00 due to bugs.

At this point I would probably migrate to qBittorrent.

@dausruddin I've been using qBittorrent for the last 3 months and I am more than happy with it. Who knows, maybe in the future I will give transmission another chance.

[diman82]

As in my example above (#122 (comment)) you could just text edit manually the name portion of any magnet (begins with &dn=) down to a short(er) length. Or you can patch metainfo.c at maybe get the display name. It's only a temporary display name until the real metadata is acquired.

          /* maybe get the display name */
          if (tr_variantDictFindStr (d, TR_KEY_display_name, &str, &len))
            {
              tr_free (inf->name);
              tr_free (inf->originalName);
              if (len > 50)
                {
                  inf->name = tr_strndup (str, 50);
                  inf->originalName = tr_strndup (str, 50);
                }
              else
                {
                 inf->name = tr_strndup (str, len);
                 inf->originalName = tr_strndup (str, len);
                }
            }

ref: cfpp2p/transmission@bf1d8bb#diff-d54a64807eeb84d2c1ffec36a2dd76c1

Worked like a charm (problem is due to a very long Cyrillic description)

[luntik2012]

the same issue in 3.00 with magnet and torrent file

[appotry]

this bug is not fixed!

Please fixed this bug!

master/libtransmission/metainfo.c

static char* metainfoGetBasenameNameAndPartialHash(tr_info const* inf)
{
    char const* name = inf->originalName;
    size_t const name_len = strlen(name);
    char* ret = tr_strdup_printf("%s.%16.16s", name, inf->hashString);

    for (size_t i = 0; i < name_len; ++i)
    {
        if (char_is_path_separator(ret[i]))
        {
            ret[i] = '_';
        }
    }

    return ret;
}

[ldesousa]

Having this issue with transmission-daemon 2.94 on Ubuntu 20.04. The issue was closed in 2017, prior to the 2.94 release. Was the fix not included in that release? Could someone please clarify? Thank you.

FYI @mikedld

[mikedld]

@ldesousa, milestone is set to 3.00.

[ldesousa]

@mikedld I just upgraded transmission-daemon to release 3.00. However the error remains and transmission is still unable to resume the download. I installed from the transmission PPA for Ubuntu:

$ apt policy transmission-daemon
transmission-daemon:
  Installed: 3.00-1ubuntu1~20.04.1
  Candidate: 3.00-1ubuntu1~20.04.1
  Version table:
 *** 3.00-1ubuntu1~20.04.1 500
        500 http://ppa.launchpad.net/transmissionbt/ppa/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status
     2.94-2ubuntu3 500
        500 http://fr.archive.ubuntu.com/ubuntu focal/universe amd64 Packages

Could there be something wrong with the release available from this PPA?

[imkyaky]

after 5 years , problem still exists. Transmission 3.00 (bb6b5a0)
The real issue is about unicode converted length

[kov-serg]

It's funny. I think it because there is no tests for this issue.
https://github.com/transmission/transmission/blob/3.00/libtransmission/metainfo.c#L39
it should be changed to something like this:

static char* metainfoGetBasenameNameAndPartialHash(tr_info const* inf)
{
    enum { name_length_limit=64 }; // 219
    char *shortName, *cleanName, *ret, *p;
    char const* name = inf->originalName;
    size_t const name_len = strlen(name);

    shortName = tr_strndup(name, name_length_limit);
    cleanName = tr_utf8clean(shortName, -1);
    ret = tr_strdup_printf("%s.%16.16s", cleanName, inf->hashString);
    tr_free(shortName);

    for(p=ret;*p;p++)
    {
        if (char_is_path_separator(*p))
        {
            *p = '_';
        }
    }

    return ret;
}

[antivirtel]

@mikedld can you please reopen the ticket at least? I see you closed it, but it's clearly not fixed in 3.0 either.

[gilad905]

As in my example above (#122 (comment)) you could just text edit manually the name portion of any magnet (begins with &dn=) down to a short(er) length.

@cfpp2p
Note on this - I've tried manually shortening the value of dn in the magnet link and adding the torrent via the webUI, it still doesn't help.
After fetching metadata for the torrent, torrent name (in webUI) changes to the original dn value. On pausing the torrent, File name too long still pops up.
I'm on v2.94

[mikedld]

@gelin, milestone for this issue is set to 3.00.

[vird]

Partially helps
~/.config/transmission/settings.json
rename-partial-files:false

[pugzly]

It's strange ~7 years later Transmission still struggles with long file names.
Due to my partition being encrypted, length of file names is limited. Renaming torrents (files, and directories) helps only partially to shorten those, download usually still fails after first few megabytes downloaded, with error message:
"Error: Unable to save resume file: File name too long"
And I need to manually force it to resume, again and again, every few megabytes. Seems like the only viable workaround is to use Deluge.

[kov-serg]

https://www.qbittorrent.org/