Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmission-qt doesn't make full use of system icon set #2174

Open
buckmelanoma opened this issue Nov 15, 2021 · 3 comments · Fixed by #2179
Open

transmission-qt doesn't make full use of system icon set #2174

buckmelanoma opened this issue Nov 15, 2021 · 3 comments · Fixed by #2179
Labels
pr welcome scope:qt type:feat A new feature

Comments

@buckmelanoma
Copy link
Contributor

buckmelanoma commented Nov 15, 2021 •
edited

transmission-qt uses built-in PNG icons for the status bar and a few other areas (encryption status). These icons don't scale well and look bad compared to parts of the UI that do use system icons (menus, filterbar, status bar). See screenshots for an example and a mockup of transmission using equatable system icons.

Built-in icons:
Screenshot_20211115_115057

System icons mockup:
Screenshot_20211115_185727
@buckmelanoma buckmelanoma mentioned this issue Nov 16, 2021
Merged
@buckmelanoma
Copy link
Contributor Author

Fixed status bar icons with PR #2179

@varlesh
Copy link

varlesh commented Nov 17, 2021

Screenshot_20211117_083523

@mikedld
Copy link
Member

mikedld commented Nov 21, 2021

@buckmelanoma, #2179 breaks Windows:
imagen

@mikedld mikedld reopened this Nov 21, 2021
@mikedld mikedld mentioned this issue Nov 21, 2021
Merged
@ckerr ckerr added type:feat A new feature and removed enhancement labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr welcome scope:qt type:feat A new feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set stock icon for speed, options and statistics buttons in qt buckmelanoma/transmission
4 participants
@ckerr @mikedld @varlesh @buckmelanoma