Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stock icon for speed, options and statistics buttons in qt #2179

Merged
merged 6 commits into from Nov 21, 2021

Conversation

buckmelanoma
Copy link
Contributor

@buckmelanoma buckmelanoma commented Nov 16, 2021

This PR sets stock system icons for the alt-speed, options and statistics buttons on the status bar in transmission-qt, replacing the poorly scaled PNG icons when possible. This essentially fixes #2174

Screenshot_20211115_185727

@buckmelanoma buckmelanoma changed the title Set stock icon for speed, options and statistics buttons for qt Set stock icon for speed, options and statistics buttons in qt Nov 16, 2021
@varlesh
Copy link

varlesh commented Nov 17, 2021

@buckmelanoma Please added for this PR another icon name for Open URL button. On Qt it's looking very ugly:
image
addEmblem(icon_open, QStringList() << QStringLiteral("emblem-web") << QStringLiteral("applications-internet")));
Emblems used for folders, but not for actiions icons on toolbar and overlay icons.
On all icon themes (Adwaita, Breeze, Faenza) available normal icon for that insert-link:
ui_.action_AddURL->setIcon(getStockIcon(QStringLiteral("insert-link"), QStyle::SP_DesktopIcon));

@buckmelanoma
Copy link
Contributor Author

@varlesh I have a second PR in the works that fixes the menu and toolbar icons. For AddUrl I think the proper icon is document-open-remote.

@ckerr ckerr self-requested a review November 18, 2021 05:46
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the problem and most of this PR, but have a soft spot for that turtle icon. It's been with Transmission from the very beginning on all platforms so I'd rather see it get replaced with a well-scaled / high-contrast friendly version of the same turtle.

Could you update this PR to leave the existing turtle (or, if you're a graphics artist, to update it with a better revision of it)?

@buckmelanoma
Copy link
Contributor Author

I tried an upscale of the turtle in Krita but it didn't turn out too well. I've updated PR to revert system override of the classic turtle.

@ckerr
Copy link
Member

ckerr commented Nov 20, 2021

Thank you for trying!

Yeah, we will probably need to redo the image from scratch in svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

transmission-qt doesn't make full use of system icon set
4 participants