Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS - incorrect behavior at Full Screen #3215

Closed
Oleg-Chashko opened this issue Jun 5, 2022 · 23 comments · Fixed by #3220
Closed

macOS - incorrect behavior at Full Screen #3215

Oleg-Chashko opened this issue Jun 5, 2022 · 23 comments · Fixed by #3220
Assignees

Comments

@Oleg-Chashko
Copy link
Contributor

Full.Screen.mp4
@sweetppro sweetppro self-assigned this Jun 5, 2022
@sweetppro
Copy link
Collaborator

@Oleg-Chashko uggh, fullscreen support really is troublesome. there are so many different scenarios which need to be accounted for. ill take another look tomorrow

@Oleg-Chashko
Copy link
Contributor Author

@sweetppro
Thanks, for some reason I think that full screen mode is not really needed by this application?

@sweetppro
Copy link
Collaborator

@Oleg-Chashko yeah it is a weird way to use Transmission, but im sure some probably find it useful...

@ckerr
Copy link
Member

ckerr commented Jun 6, 2022

I hate to make macOS UI suggestions based on other platforms, but FWIW neither the GTK nor Qt apps have full-screen.

I'd be OK with removing it unless it's idiomatic for macOS apps to have a full-screen mode

@GaryElshaw
Copy link
Contributor

It is 'normal' to have that function.

@Oleg-Chashko
Copy link
Contributor Author

Not all macOS applications use full screen mode.
The developer uses this mode at his own discretion in his application.
It seems to me that almost no one uses this mode in this application.
Since this mode was broken a long time ago and maybe never worked correctly.
And there is no one in the larger community who created this issue before me.
And I wouldn't have created it this issue because I don't use full screen mode in this app.

Example:

Screen

@sweetppro
Copy link
Collaborator

It would definitely save a lot of headaches to remove full screen support

@Oleg-Chashko
Copy link
Contributor Author

To solve the problem with full screen mode:
need to create an algorithm that disables the "Auto resize" option when using full screen mode.
With "Auto resize" option disabled there is no problem with full screen mode.
I have already described this conflict.

Screen Shot 2022-06-06 at 10 14 03

@sweetppro
Copy link
Collaborator

@Oleg-Chashko are you running the latest version? I’ve already done this

@sweetppro
Copy link
Collaborator

sweetppro commented Jun 6, 2022

The issue I’m facing right now is showing and hiding the filter/status bar if the toolbar is shown (in full screen mode) - but only if either/both is not showing when full screen is enabled…

I’m out excercising now, and will have another crack at this when I get home this afternoon.

@Oleg-Chashko
Copy link
Contributor Author

@Oleg-Chashko are you running the latest version? I’ve already done this

v.3.00+8d61f07930

@sweetppro
Copy link
Collaborator

Which version of macOS?

@Oleg-Chashko
Copy link
Contributor Author

Which version of macOS?

macOS Monterey v.12.4 (21F79)

@sweetppro
Copy link
Collaborator

Hmm,
That’s what I’m running.
And the issue you describe is not happening for me. The issue I have is the issue I described above

@sweetppro
Copy link
Collaborator

sweetppro commented Jun 6, 2022

See here https://github.com/transmission/transmission/pull/3191/files

specifically windowWillEnterFullScreen And windowDidExitFullScreen

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Jun 6, 2022

Fullscreen mode always worked fine.
Only it always conflicted with the "Auto Resize" feature that was on.

172131137-178b67fb-0ab2-4fc0-8b6d-842f5ba5a3be.mp4

@sweetppro
Copy link
Collaborator

sweetppro commented Jun 6, 2022

Fullscreen mode always worked fine.
Only it always conflicted with the "Auto Resize" feature that was on.

That’s what I don’t understand, I disabled auto resize while in full screen in #3195

@Oleg-Chashko
Copy link
Contributor Author

Fullscreen mode always worked fine.
Only it always conflicted with the "Auto Resize" feature that was on.

That’s what I don’t understand, I disabled auto resize while in full screen in #3195

Unfortunately, "auto resize" is not disabled in full screen mode.

Screen.mp4

@Coding4Coffee
Copy link

+1 for getting rid of full screen support. I would not say that a torrent client is a primary use day to day, and most users will be multi tasking in the background. The extra screen real estate full screen provides, does not add any real benefit to the user experience imo, apart from a bunch of white space.

The auto resize function is more than enough for my use case

@ckerr
Copy link
Member

ckerr commented Jun 6, 2022

I'm also leaning towards "remove".

Code that doesn't exist has fewer bugs than code that exists...

sweetppro added a commit to sweetppro/transmission that referenced this issue Jun 6, 2022
removed fullscreen support, as it opens a can of worms trying to fully support it....

transmission#3215 (comment)
ckerr pushed a commit to sweetppro/transmission that referenced this issue Jun 7, 2022
removed fullscreen support, as it opens a can of worms trying to fully support it....

transmission#3215 (comment)
ckerr pushed a commit to sweetppro/transmission that referenced this issue Jun 7, 2022
removed fullscreen support, as it opens a can of worms trying to fully support it....

transmission#3215 (comment)
ckerr pushed a commit to sweetppro/transmission that referenced this issue Jun 8, 2022
removed fullscreen support, as it opens a can of worms trying to fully support it....

transmission#3215 (comment)
ckerr pushed a commit that referenced this issue Jun 8, 2022
removed fullscreen support, as it opens a can of worms trying to fully support it....

#3215 (comment)
@Oleg-Chashko
Copy link
Contributor Author

The full screen mode does not work properly.

Screen Shot 2022-06-13 at 08 14 36

@Oleg-Chashko Oleg-Chashko reopened this Jun 13, 2022
@GaryElshaw
Copy link
Contributor

See #3278

@Oleg-Chashko Oleg-Chashko changed the title macOS: incorrect behavior at Full Screen macOS - incorrect behavior at Full Screen Jun 13, 2022
@Oleg-Chashko
Copy link
Contributor Author

v.3.00+c6b49e99d8 - Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants