Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt-i keyboard shortcut for torrent inspector doesn't work #4829

Closed
pleasantone opened this issue Feb 11, 2023 · 7 comments · Fixed by #5054
Closed

alt-i keyboard shortcut for torrent inspector doesn't work #4829

pleasantone opened this issue Feb 11, 2023 · 7 comments · Fixed by #5054

Comments

@pleasantone
Copy link

What is the issue?

Browser is MacOS Safari

Keyboard shortcut hint says to use "Alt-I" to open the inspection window.
This would, using a Mac keyboard, usually translate to either Option-I (correct) or Command-I (problematic).
Neither work. Command-I is problematic because the command keys are often in use by the browser (e.g. Command-O opens a dialog box).

Fixes:

  • Allow option- versions of the keys through the web interface.
  • Better yet, allow straight keys again (just like transmission 3.0), which will work much better on mobile screens!

Which application of Transmission?

Web client

Which version of Transmission?

4.0.0-stable

@ckerr ckerr added scope:web pr welcome bug:regression good first issue For people who'd like to start contributing labels Feb 11, 2023
@ckerr ckerr changed the title web client UI issue - keyboard shortcuts don't work alt-i keyboard shortcut for torrent inspector doesn't work Feb 11, 2023
@ckerr
Copy link
Member

ckerr commented Feb 11, 2023

Confirmed on macOS using both Safari and Chrome.

Works on Linux in Chrome.

Probably just a poor choice of accelerators; let's try some different defaults.

@tessus
Copy link
Contributor

tessus commented Feb 25, 2023

let's try some different defaults.

Does this mean we can change them somehow by hacking a file?

@ckerr
Copy link
Member

ckerr commented Feb 25, 2023

If you're willing to re-webpack the code, yes!

The actions and their shortcuts are in web/src/action-manager.js

If you have npm installed, you can rebuild transmission-app.js with:

$ cd web/
$ npm install
$ npm run build

And then use that new copy of transmission-app.js instead of the old one.

@tessus
Copy link
Contributor

tessus commented Feb 25, 2023

Nice, I can play around with this. Cool.

@tessus
Copy link
Contributor

tessus commented Feb 25, 2023

I have changed the shortcuts to:

image

and it works brilliantly. Thanks for the tip how to change them! 👍

Btw, I've tried to use Control+Shift+A for Deselect all, but this didn't work. The Shift seems to be ignored, thus it just selects all.

@ckerr
Copy link
Member

ckerr commented Feb 25, 2023

@tessus unmodified shortcuts are problematic. If you could add some modifiers on IOPRS that work on both Safari and Chrome then that would be great for a bugfix patch!

@tessus
Copy link
Contributor

tessus commented Feb 25, 2023

Ah, ok. In that case I just make the others also use Control and send a PR.

It's just that Pause and Preferences both start with P and I have no idea how U has anything to do with Pause, except maybe it's the 3rd letter in the word that hasn't been used yet. ;-)

Also, Control+O (and I and P) are not easy to do with only one hand on a MacBook, b/c there is no right ctrl key. However, this is just an observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants