New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change alt to control for shortcuts #5054
Conversation
@tessus Thanks you for doing this! ❤️ Since it's easier for you to test (since you have a Mac) could you please confirm that all these shortcuts work on both Safari and Chrome? IIRC there was some potential conflict e.g. with Ctrl+O being the browser's "open" as well but TBH I'm fuzzy on the details and might be misremembering -- so the shortest path is to just test and make sure. I believe FF behaves similarly to Chrome so testing on Safari & Chrome should be sufficient |
Yep, it works on Firefox, Chrome, and Safari. |
Hmm, I just saw that I cannot commit the generated file. I did that only, because it wsa in the source tree. Shall I remove it from my PR? |
Yes, please. I don't think we've ever had anyone submit a malicious patch, but webpacked files are difficult to review. Letting the bots run webpack is safer than doing manual review. |
a9b1d57
to
4522aae
Compare
Done. |
6c21934
to
2b57661
Compare
I'm slightly confused why you committed my changes again. Now they are no longer gpg signed. Anyway, not that important, just curious. |
@tessus I was just rebasing them on top of the lastest commit in |
I see, thanks for the info. I usually only rebase in a branch when there are conflicts, which is why I didn't understand why a rebase was done. |
Notes: Fixed broken keyboard shortcuts on desktop Safari. |
I changed the modifier key from
Alt
toControl
, which makes it possible to use it on macOS.The
Deselect all
shortcut has also been changed fromControl+A
toControl+D
.fixes #4829