refactor: don't store torrent hashes in QStrings #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets replace the hashString QString allocation with a compile-time array that's included in sizeof the Torrent struct that owns it.
|
appveyor CI failure is unrelated -- it's a regression in MSVC and I've got a workaround for it in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor optimization to the Qt client's
Torrentclass: keep the hash in astd::array<uint8_t, 20>instead of in aQString. Since the size of the array is known at compile time, it can be built into the Torrent class and the extra heap allocs for QString's internals can be avoided.This saves about 5 MB from the RES size on my 15K torrent testbed, which is better than I expected, considering that the raw hashString char array size was 41 bytes so the raw data savings is only (15K torrents * (41 bytes - 20 bytes)) = 0.31 MB.
5 MB out of 15K torrents isn't a huge win; however, since we don't display the hashString anywhere except for in the details dialog, building the string on demand is not expensive.