Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option of automatically picking up URLs from the clipboard on window focus #1633

Merged
merged 8 commits into from Jan 23, 2022

Conversation

varesa
Copy link
Contributor

@varesa varesa commented Feb 28, 2021

This PR aims to implement #1515 for the Qt frontend

When the window is focused, if the user has opted in to the functionality in the preferences, the clipboard will be searched for URLs.

(FYI: This has been implemented as part of a university course)

@ckerr ckerr added the scope:qt label Oct 7, 2021
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@varesa sorry for not reviewing this sooner. If you're still interested in this PR, feel free to fix up the merge conflicts that have accumulated over time and @ me. Thanks!

@varesa
Copy link
Contributor Author

varesa commented Jan 18, 2022

Hi @ckerr sorry also for taking so long to respond.

Rebased the changes to current main

qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.h Outdated Show resolved Hide resolved
* Syntax updates

* Add tooltip for checkbox
qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.cc Outdated Show resolved Hide resolved
qt/MainWindow.h Outdated Show resolved Hide resolved
@ckerr ckerr added the needs update The PR has needs to be updated by the submitter label Jan 21, 2022
* Syntax updates

* Rename 'read_from_clipboard_'
@ckerr ckerr added enhancement and removed needs update The PR has needs to be updated by the submitter labels Jan 23, 2022
@ckerr ckerr merged commit 032e01c into transmission:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants