Added primitive CORS header support #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
Oct 7, 2021
|
@ckerr I've added the nullptr check 😄 |
|
Thanks! |
|
You are welcome! 👍 @ckerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This code is based on the PR of frecristovao (#1010).
In the initial PR, I saw that the code was never resubmitted after Transmission's moving away from Gitflow.
Code:
In my eyes, it made sense that setting any CORS headers would happen after authorization checks of the client's IP address and the anti-brute force check. If I need to move the setting of the headers, please let me know and I will resolve that.