WebUI: Fix removing selected torrent(s) not working #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir data, make sure to only send torrentIds, not full torrent objects, via RPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Transmission 3.00 and the new WebUI, removing one or more selected torrents without removing their data did not work: The torrent(s) simply weren't removed.
This is because the web client would send a list full
Torrentobjects instead of just torrent IDs via RPC to the server, which the server then simply ignored.This PR combines the functions
Remote.removeTorrents()andRemote.removeTorrentsAndData()into one function, sending only IDs as expected.Note: web programming and Javascript are not my forté, so this fix may be utter nonense. It does do the trick on my machine however.
Fixes #2015 .