Qt 6 support #2069
Merged
Qt 6 support #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While still available, QRegExp has been moved to Qt6::Core5Compat module and is not part of Qt6::Core.
The latter is not part of Qt6::Core. The former is a private utility in Qt6::Network; using it for now, until (and if) we switch to something non-Qt-specific.
Although available for a long time, this state either didn't apply to progress bars before Qt 6, or was deduced based on bar size. With Qt 6, failing to specify it results in bad rendering.
While still available, QStringRef has been moved to Qt6::Core5Compat module and is not part of Qt6::Core. Related method (e.g. QString::midRef) have been removed in Qt 6.
The latter was deprecated and replaced with the former in Qt 5.6.
This property has been deprecated in Qt 5.15 and removed in Qt 6.
WinExtras module (providind the latter helper) has been removed in Qt 6.
While still available, QTextCodec has been moved to Qt6::Core5Compat module and is not part of Qt6::Core.
Instead of being a standalone class, its definition has changed to QList<QString> template specialization in Qt 6.
The latter was deprecated in Qt 5.8 and removed in Qt 6.
It has been removed in Qt 6. Since the original issue this code was solving was caused by future reuse, just don't reuse futures and create new finished ones when necessary.
The latter has been changed to a typedef for QList<>, which might not be what one wants, and which also changed behavior a bit leading to compilation errors.
Operator+ for enum values has been deleted in Qt 6, so using operator| instead. Then, there's no conversion from QFlags<> to QVariant, so need to cast to int.
ckerr
reviewed
Nov 3, 2021
ckerr
approved these changes
Nov 3, 2021
|
ok we need a transmission 3.01 release for this to ship in distros because all of them are shipping with the vertical progress bar glitch as it's in 3.00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Qt 6.2.1. More testing and careful review required.