gtk: accept dropping URLs from browsers onto the main window #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike files, which come as a URI list, links dragged from browsers have textual selection types: - Firefox: text/plain;charset=utf-8 - Chrome: UTF8_STRING If the URI list for files is empty, try to pass the selection text to add_from_url().
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes URLs closer to files in terms of convenience, since both can now be dropped onto the main window without the user having to open a Open/Open URL dialog.
Unlike files, which come as a URI list, links dragged from browsers have textual selection types:
text/plain;charset=utf-8UTF8_STRINGIf the URI list for files is empty, try to pass the selection text to
add_from_url().EDIT: a backport of this patch for the 2.94 release, that does not yet use GTK through C++, is now available as 1f9287b.