fix cross build #2576
Merged
fix cross build #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant include, ${UTP_INCLUDE_DIRS} is included already to fix
cross build error with buildroot:
x86_64-linux-g++: ERROR: unsafe header/library path used in cross-compilation: '-isystem' '/libutp'
ckerr
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Thanks for the PR!
TP_TOP isn't defined anywhere from what I can tell. Looks like this block was there in the first draft of this file seven years ago; most likely it was draft code that accidentally got merged. How has this wart gone unnoticed all these years 💫
|
CI failure is unrelated to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant include, ${UTP_INCLUDE_DIRS} is included already to fix
cross build error with buildroot:
x86_64-linux-g++: ERROR: unsafe header/library path used in cross-compilation: '-isystem' '/libutp'