Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Labels section in transmission-remote output. #2597

Merged
merged 2 commits into from Feb 10, 2022

Conversation

vchimishuk
Copy link
Contributor

I noticed that transmission-remote output is broken, Labels section is not correct.
Current output:

$ ./transmission-remote -t 2 -i 
NAME
  Id: 2
  Name: Manson
  Hash: c6cdcb6ce6338e29d99f9f03a938809842b47990
  Magnet: magnet:?xt=urn:btih:c6cdcb6ce6338e29d99f9f03a938809842b47990&dn=Manson&tr=http%3A%2F%2Fbt2.t-ru.org%2Fann%3Fpk%3D1e76b76ff7f5910c77ec5f5a41bd220b&tr=http%3A%2F%2Fretracker.local%2Fannounce
, three, two, one, baz

TRANSFER
...

With proposed fix:

$ ./transmission-remote -t 2 -i 
NAME
  Id: 2
  Name: Manson
  Hash: c6cdcb6ce6338e29d99f9f03a938809842b47990
  Magnet: magnet:?xt=urn:btih:c6cdcb6ce6338e29d99f9f03a938809842b47990&dn=Manson&tr=http%3A%2F%2Fbt2.t-ru.org%2Fann%3Fpk%3D1e76b76ff7f5910c77ec5f5a41bd220b&tr=http%3A%2F%2Fretracker.local%2Fannounce
  Labels: baz, three, two, one

TRANSFER
...

Commit which introduced the bug -- 677dc73#diff-f00d4a85f7112ae6a3f8db4ad607edaa264e8485ad5c5a5803f25fa940ef0457L973

@ckerr
Copy link
Member

ckerr commented Feb 10, 2022

Commit which introduced the bug -- 677dc73#diff-f00d4a85f7112ae6a3f8db4ad607edaa264e8485ad5c5a5803f25fa940ef0457L973

Ouch. We need integrated tests for transmission-remote

@ckerr
Copy link
Member

ckerr commented Feb 10, 2022

CI failure is unrelated to PR

@ckerr ckerr merged commit 8149ff0 into transmission:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants