Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for resuming magnet links #2702

Merged
merged 11 commits into from Feb 24, 2022
Merged

Conversation

sweetppro
Copy link
Collaborator

magnet links are now saved as a text file the Torrents folder as .magnet files.

macOS support is added in PR #2686:

magnet links are now saved as a text file the `Torrents` folder as `.magnet` files.
@sweetppro
Copy link
Collaborator Author

no idea why my PRs keep failing checks...
:(

libtransmission/session.cc Outdated Show resolved Hide resolved
libtransmission/magnet-metainfo.h Outdated Show resolved Hide resolved
libtransmission/torrent.cc Outdated Show resolved Hide resolved
libtransmission/torrent-magnet.cc Outdated Show resolved Hide resolved
libtransmission/torrent-ctor.cc Show resolved Hide resolved
libtransmission/torrent-ctor.cc Outdated Show resolved Hide resolved
libtransmission/torrent.cc Outdated Show resolved Hide resolved
sweetppro and others added 6 commits February 24, 2022 16:26
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
oops, we should be deleteing the magnetFile from the `Torrent` dirictory
@ckerr
Copy link
Member

ckerr commented Feb 24, 2022

no idea why my PRs keep failing checks... :(

There is a known issue in CI in the rename / move sanity tests, that is my bug -- it's just taking longer to fix than I expected. If that's the error you're getting, feel free to ignore it

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff. Thank you for doing it!

libtransmission/magnet-metainfo.cc Outdated Show resolved Hide resolved
libtransmission/magnet-metainfo.h Outdated Show resolved Hide resolved
libtransmission/session.cc Outdated Show resolved Hide resolved
libtransmission/torrent-ctor.cc Outdated Show resolved Hide resolved
@sweetppro sweetppro requested a review from ckerr February 24, 2022 20:55
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PR needs you to run ./code-style.sh in the top-level directory to run clang-format to make the code style CI bot happy, but that's the only remaining issue that I see.

@sweetppro
Copy link
Collaborator Author

sweetppro commented Feb 24, 2022

LGTM. The PR needs you to run ./code-style.sh in the top-level directory to run clang-format to make the code style CI bot happy, but that's the only remaining issue that I see.

hmmm,
its not working for me...
Im running macOS 12.2.1

I get the error:

find: clang-format: No such file or directory

@ckerr
Copy link
Member

ckerr commented Feb 24, 2022

no worries, I can get it

@ckerr ckerr merged commit 943b579 into transmission:main Feb 24, 2022
@sweetppro sweetppro deleted the magnet_link branch February 24, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants