New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for resuming magnet links #2702
Conversation
magnet links are now saved as a text file the `Torrents` folder as `.magnet` files.
no idea why my PRs keep failing checks... |
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
… into magnet_link
oops, we should be deleteing the magnetFile from the `Torrent` dirictory
There is a known issue in CI in the rename / move sanity tests, that is my bug -- it's just taking longer to fix than I expected. If that's the error you're getting, feel free to ignore it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff. Thank you for doing it!
resolved issues, and applied suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The PR needs you to run ./code-style.sh
in the top-level directory to run clang-format to make the code style CI bot happy, but that's the only remaining issue that I see.
hmmm, I get the error:
|
no worries, I can get it |
magnet links are now saved as a text file the
Torrents
folder as.magnet
files.macOS support is added in PR #2686: