add magnet link support to transmission web #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works well in my custom build. Very useful, thanks ! |
|
Sorry that it's taken me so long to get back to do code review on this; I haven't forgotten about it. |
ckerr
approved these changes
May 24, 2022
|
Oh, nice. Thanks for merging 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements magnet link support. Adds button to preferences which allows you to register handler. I decided to open the dialog - option to skip it can be implemented later and this felt safer.
Since browser do not have a simple way to figure out if a handler is actually registered I save it to localStorage. Also Firefox does not support unregisterProtocolHandler, but I still allow the use of the unregister button, because otherwise there would be no way to reregister the handler if user cleared it in settings...
This is another attempt at #349 and fixes #346
Also, the dialog window opening is a bit hacky, but this was only place where to open the dialog without getting an error