Add "Verify Local Data" to context menu #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GTK and Qt client have this in the context menu already, so adding ping @DevilDimon for code review / feedback |
DevilDimon
approved these changes
May 11, 2022
Coeur
force-pushed
the
coeur/verifyLocalData
branch
from
a15ca80
to
5ba203f
Compare
ckerr
added a commit
that referenced
this pull request
May 20, 2022
commit 2e25370cc5abf48697663a701a2d9e21a6e74dd6
Author: A Cœur <coeur@gmx.fr>
Date: Fri May 20 12:07:17 2022 +0800
Fix QuickLook (#3001)
* Fix QuickLook symbol not found; add file sort and filesize
commit f71ace588f918cd2de2f954e53e02fe982187862
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed May 18 15:49:40 2022 -0500
fix: assertion failed: task->loc.byte <= task->end_byte (#3109)
commit 3c056001b1c498ab7d8dc1e21f15d53032cbe946
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue May 17 12:48:39 2022 +0800
support pasting multiple magnet links (#3087)
commit a28b07b3904b98d0115a0fc929d690ba10054d60
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon May 16 13:48:43 2022 -0500
Revert "refactor: move tr_torrent callbacks to tr_session (#3003)" (#3104)
This reverts commit 27fbfd8da62d39127b891cb8dc481938fbf13d72.
Fixes #3088.
commit e23a4b35891d96dcf9614ddaa9595aea4a1b5563
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue May 17 01:08:20 2022 +0800
refactor copyMagnetLinks (#3086)
commit e286e45ac848dc0c3497390fc81a47b51890902b
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon May 16 09:06:18 2022 -0500
fixup! refactor: use smaller integral types in some structs (#3005) (#3096)
fix GTK client file progress % regression
Fixes #3063.
commit 2293f4336af1abe52a487fe1d4c6b55ce35c007d
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon May 16 00:06:17 2022 -0500
perf: use fast_float to parse floating-point numbers (#3092)
commit ebd1a0b7bf4096d2f20c577aebb68dfa67c3efd6
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun May 15 20:49:25 2022 -0500
deps: update web client build deps (#3095)
* deps: change web build-dep from node-sass to sass
https://sass-lang.com/blog/libsass-is-deprecated and dart sass is the
recommended replacement.
* deps: yarn upgrade-interactive
* deps: update babel dep to 7.17
* deps: update eslint
* deps: update prettier
* deps: update svgo
* deps: update webpack to 5.72.1
* deps: update webpack-bundle-analyzer to 4.5.0
* deps: update webpack-cli to 4.9.2
* deps: update webpack-dev-server from 3.11.3 to 4.9.0
* deps: replace svgo, svgo-loader, url-loader with webpack asset/inline
* chore: rename "style" dir as "assets"
* deps: update stylelint from 13.13.1 to 14.8.2
* deps: bump terser-webpack-plugin from 5.1.4 to 5.3.1
* deps: bump css-loader from 5.2.7 to 6.7.1
* deps: bump css-minimizer-webpack-plugin from 3.0.2 to 3.4.1
* deps: bump mini-css-extract-plugin from 1.6.2 to 2.6.0
commit aa502f93127d7009722ffc884d5a8a222fa8914f
Author: Dmytro Lytovchenko <dmytro.lytovchenko@gmail.com>
Date: Sun May 15 18:32:22 2022 +0200
Modernize blocklist.cc: Rename, move members inside struct (#2010)
* Modernize blocklist.cc to C++
* Modernize blocklist.cc: Renamed BlocklistFile struct and moved IPv4 range struct inside it
Modernize bandwidth.cc: Review notes; Promote container of blocklists in session to vec of unique_ptrs
commit 25ef121d71e3ac4ab5072fd5a5819f585b7b2429
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sun May 15 10:14:54 2022 +0800
Add "Verify Local Data" to context menu (#3025)
commit 60254710b8e8951a21e0e86dfdfce8fbc993af98
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sun May 15 03:00:55 2022 +0800
Rename sortTorrentsAndIncludeQueueOrder and nonEmptyComponentsSeparatedByCharactersInSet (#3051)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 82bede40d1e30c2017831c99108381c8c0ae6425
Author: SweetPPro <sweetppro@users.noreply.github.com>
Date: Sat May 14 19:57:22 2022 +0200
fix for macOS "Stay within the global bandwith limits" always displaying true (#3079)
commit 36e6d4ed0797f3652c31cd0aa5130c4c9a2f3e2d
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat May 14 11:17:55 2022 -0500
chore: remove unused header fdlimit.h (#3084)
commit 27fbfd8da62d39127b891cb8dc481938fbf13d72
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat May 14 10:00:13 2022 -0500
refactor: move tr_torrent callbacks to tr_session (#3003)
* refactor: move tr_torrent callbacks to tr_session
* Support tr_sessionSet* (#3044)
Co-authored-by: Antoine Cœur <coeur@gmx.fr>
commit c1f5911fc72bd5c46179aee40e76a2488df3bee4
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 21:20:56 2022 +0800
'beginSheet:modalForWindow:modalDelegate:didEndSelector:contextInfo:' is deprecated: (#3031)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 340f88bc1238fbd42be820298e050e9fa94c967b
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 15:53:30 2022 +0800
Fix "The left operand of '<' is a garbage value" (#3042)
commit 79274bb33567b8143a340e0acf07e3ec04db8039
Author: wiz78 <wiz78@users.noreply.github.com>
Date: Sat May 14 08:57:20 2022 +0200
macOS: disable App Nap. Fixes #577 (#874)
* disable App Nap
* Update Controller.m
merged with upstream changes
* Delete Controller.m
* chore: code-style.sh
Co-authored-by: Simone Tellini <wiz78>
Co-authored-by: Simone Tellini <simone@Argon.local>
Co-authored-by: Simone Tellini <simone@tellini.info>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 5d52da872693dcbabbb34cc5711985ab12feaaf1
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 13:31:24 2022 +0800
Address format conversion warnings in localizations (#3059)
commit 659969a4361ec480116505ce50e1a1e1c9f1d49a
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 10:27:31 2022 +0800
Fix Display window option incorrectly enabled on start (#3056)
commit 67f6562ae41616f711a82e3a1b61bb265ddec779
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 08:54:10 2022 +0800
Updating group icon style for newer macOS (#3065)
commit 7ab2fbfbd651a9e30bf7d3e536647a947409a6dc
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 07:48:33 2022 +0800
Adopting .clang-format-include and .clang-format-ignore (#3047)
commit 5026d4392006df8c429a9c351d07b20c08b31946
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat May 14 05:03:07 2022 +0800
Add ⌘C support (#3072)
commit 7b34c09f26ecc960673ec9ba0abfe01d8a34087d
Author: ewtoombs <2224848+ewtoombs@users.noreply.github.com>
Date: Fri May 13 11:20:57 2022 -0400
Wrote a guide on headless usage. (#3049)
The guide uses `transmission-daemon` and `transmission-remote`. It makes some
basic security recommendations, but it does not include instructions for system
integration, i.e. systemd, etc.
commit d5533ee64885c3116f4ecc054331a30639e2df1d
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue May 10 22:54:39 2022 +0800
Fix "Port checker returned invalid status: 0" (#3064)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit e7312eba142b15472b89c8dd77a0745605c77a08
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon May 9 09:47:56 2022 +0800
Rename "Remove Data File" to "Trash Data File" (#3057)
commit 53b3a6517ae9aed5d2972c6fbe73d10ca7267dc9
Merge: d3e1c83c9 1f419a3a6
Author: Mitch Livingston <livings124@mac.com>
Date: Fri May 6 07:21:41 2022 -0400
Merge pull request #3053 from Coeur/coeur/customGroups
commit 1f419a3a6fb322da3f67d90c8e90ec57efacf2d6
Author: Cœur <coeur@gmx.fr>
Date: Thu May 5 16:14:06 2022 +0800
Fix retrieving groups with predicates
commit d3e1c83c9b348c2ee2538498f9938ded16fea1a5
Author: Antoine Cœur <coeur@gmx.fr>
Date: Thu May 5 07:54:41 2022 +0800
Address build warnings (#3052)
commit a57d2659686e227a26c1d86a30feee669903b77f
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon May 2 05:55:09 2022 +0800
Set recommended CODE_SIGN_IDENTITY and PRODUCT_BUNDLE_IDENTIFIER (#3043)
commit 9069e4c9102ca94638f9febebb57bf7c10db1017
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon May 2 02:06:32 2022 +0800
Fix TeamCity Code Style (#3045)
commit d498aa1ae1c94cccfeca10447f0a17950aee6b19
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sun May 1 20:26:45 2022 +0800
The left operand of '+' is a garbage value (#3041)
commit 88a0b292d942df03f8700092bb5f1b4a12187fa8
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 30 23:30:49 2022 -0500
fixup: fix fd regression in tr_open_files (#3036)
Fixes #3032.
commit 4cc952f0ca607c681f56808c3dff7022bfe3d5ee
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 30 18:43:32 2022 -0500
fixup! fixup! fix: ensure all bytes read / written to file (#2682) (#2780) (#3035)
fix spurious tr_error being set when reading up to eof
Fix error introduced in the previous fixup :P
commit c8f5cff564cc8810b349c466e4db866075c4c6f3
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 30 16:57:11 2022 -0500
fixup! fixup! fix: ensure all bytes read / written to file (#2682) (#2780) (#3033)
fix spurious tr_error being set when reading up to EOF.
This regression generated invalid error messages when no error occurred.
commit 7eecdca68ec6e34987d3e1fd7f4f20672771d3b1
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sun May 1 01:49:52 2022 +0800
clang-format version 12.0.1 + 14.0.3 (#3027)
commit 81ef0de2f4fc82635dd4cb1b544b7b4a948c2ae1
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Fri Apr 29 17:52:53 2022 -0500
build(deps): bump async from 2.6.3 to 2.6.4 in /web (#3023)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 34ec2f5aa4fd4076a94ad6bbea9058e8ef5977f5
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat Apr 30 06:51:40 2022 +0800
Adopting lightweight generics (#2974)
commit aafedcaae11ef73a7008a4013c9a99cd3ad97bd8
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat Apr 30 05:44:59 2022 +0800
Address deprecations with NSKeyedUnarchiver (#2973)
commit a4b1c2cadcbdd1cf378b6c97b717121dd8c85f1f
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 29 14:40:52 2022 -0500
deps: update dht to 0.27 (#3015)
commit e4221916b1360ddaf6fe93385d08bd488bc571bd
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 29 12:44:22 2022 -0500
fix: invalid tr_peerMsgsImpl::prefetchCount value (#3024)
* fix: invalid tr_peerMsgsImpl::prefetchCount value
This count could get corrupted due to imprecise bookkeeping when
processing peers' cancel messages. This PR replaces the field with
a `prefetched` flag in the struct that represents a peer request.
This approach has simpler code, simpler logic, and is harder to break.
commit d487a5d8d738ccfa055560642b2c34286f87d826
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 29 08:32:15 2022 -0500
refactor: make tr_swarm.peers a std::vector (#3017)
commit 5dbe1f46690f5dc90cff5eb2755f59949c3dc399
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 28 21:35:47 2022 -0500
refactor: replace tr_fdlimit with tr_open_files (#3016)
commit 2f16e4a1430f703d09cb3ae339084e161b46900b
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 28 12:51:18 2022 -0500
deps: update libdeflate to v1.10 (#3014)
commit a40068224734e339932b77f9fbb2bf2b4f61fc38
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 28 11:52:07 2022 -0500
refactor: remove unused tr_torrent fields (#3013)
* refactor: remove unused field tr_torrent.prefetchMagnetMetadata
* refactor: remove unused field tr_torrent.dhtAnnounce6InProgress
* refactor: remove unused field tr_torrent.dhtAnnounceInProgress
* refactor: fold etaULSpeed and etaDLSpeed into one field
* refactor: re-arrange fields to avoid padding
commit 5e769fbc55049c39b78eb2f8a534999e8426a760
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 28 10:52:26 2022 -0500
refactor: make tr_recentHistory a template class (#3012)
This gives more flexibility on the size of the count bins, so we can save space on smaller counts
commit d8c5c6572559136569f00e0c9c3cb068b6256938
Author: maxz <6818198+maxz@users.noreply.github.com>
Date: Thu Apr 28 16:16:19 2022 +0200
Specify the umask and IPC socket permission as strings. (#2984)
* Support specifying the umask as a string representing an octal number.
* Save the umask as a string representing an octal number.
* Support specifying the IPC socket permission as a string representing an octal number.
* Save the IPC socket permission as a string representing an octal number.
* Add a `base` parameter to `tr_parseNum()` for specifying the radix.
commit 7c2477dddf8a51491abc51dd7019edb95911d378
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 28 08:44:24 2022 -0500
refactor: reduce field padding in some structs (#3006)
* refactor: use smaller integral types in tr_bandwidth
* refactor: re-arrange tr_torrent fields to avoid padding
* refactor: re-arrange tr_torrent fields to avoid padding
* refactor: re-arrange tr_announcer fields to avoid padding
commit bf655a921d50d56fe324f161b09244c78285df60
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 27 20:06:51 2022 -0500
refactor: use smaller integral types in some structs (#3005)
commit fca85c2f4de7e19a471653f162a0c064f50998c6
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 27 12:20:55 2022 -0500
refactor: add Handshakes helper class in peer-mgr (#3002)
commit 304fffa6b36c88441a7cb9bdabe9995aad4e88e2
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 27 10:41:28 2022 -0500
refactor: intern tr_torrent.bandwidth_group_ (#3000)
Most use cases involve either (a) using the default group or (b) sharing
a group with other torrents. In both cases, using a tr_quark is cheaper
than a std::string.
commit a818ac9b13ba5422b6086ac8f100162cc49ba096
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 26 19:51:24 2022 -0500
perf: limit the scope of bitfield assertions (#2994)
Fixes #2830.
commit 20be816fee84029c69c2f0ecff87b411035c6ee3
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 26 18:24:07 2022 -0500
perf: faster file-lists in the GTK client's details dialog (#2993)
* perf: faster file tree building in GTK client
* perf: faster GTK client FileList
* use a std::map for faster node lookup when building a file tree
* use tr_get_mime_type_for_filename() for mime-type lookup
* remove unnecessary layer of indirection when building the
keys for lookuops in the mime-type icon cache
* be more careful to only call operator= on proxies whose values
have actually changed, since that assignment is expensive
commit 0025363edebf3c3f65accc60b5d8fe0a43a42b4f
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 26 11:11:21 2022 -0500
perf: faster file priorities (#2992)
commit 42713c6716e748031d5de4a4e0f94b28b7ec0484
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue Apr 26 22:11:44 2022 +0800
OS X → macOS (#2986)
commit 026174ae51fb5dfc5c2b41a69d984ca4c6ac3135
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue Apr 26 07:19:09 2022 +0800
update documentation links (#2985)
commit c708b83a3f2093f24160bd3b6a7079c246552aa7
Author: Antoine Cœur <coeur@gmx.fr>
Date: Tue Apr 26 07:18:35 2022 +0800
update documentation links (#2985)
commit b734b17a4bad943ecda1d2b59ee630f5de5d6e59
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon Apr 25 21:12:21 2022 +0800
adding missing transmission targets (#2976)
commit ca13842c8458ee2c84f3a55befae0e36e95eca05
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 24 22:43:26 2022 -0500
refactor: make tr_torrent::verify_state_ private (#2982)
commit aa2bb367ab02474ddc4370bac2275ee9076c6b46
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 24 20:49:52 2022 -0500
chore: iwyu cleanup (#2981)
commit 7f9264940ed161afd297a6255127fcb8b957865c
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon Apr 25 04:34:30 2022 +0800
Compatibility to build on the last macOS 32 bit system with its last compatible Xcode (#2844)
* Compatibility to build on the last macOS 32 bit system with its last compatible Xcode
* Code review: Compatibility declarations
* compatibility with `make`
* Code review: headers
* Avoiding dummy NSImageSymbolConfiguration implementation
* clang-format
* Don't force-include compat header
* Remove compat header from pch header
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
commit 07dc81170a8ecc133d499d970cb7c63ce08e9758
Author: qu1ck <anlutsenko@gmail.com>
Date: Sun Apr 24 12:34:32 2022 -0700
Fix fields handling in session-get (#2972)
commit d4e1b32e3879627f78184c4b538509fab29b9245
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 24 12:46:44 2022 -0500
fix: corruptin when downloading webseeds (#2978)
Fixes #2909.
commit fe40692dea0869003dc30c97d2ee5e64d3944779
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon Apr 25 01:15:02 2022 +0800
Balancing HTML opening-closing tags (#2975)
commit 4f70baa27ebea5a446dd1ac88e483504e9a4d203
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 22:41:30 2022 -0500
fix: cell-renderer up/down ui layout order (#2970)
commit 0a3018d706494d4327876b4dcda5a7f56baf0fef
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 16:15:06 2022 -0500
refactor: decouple peer limits from fdlimit (#2969)
commit 1ebac744a5bd5d5a6085ee9aac2a650aab05f4ce
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 14:56:54 2022 -0500
build: re-enable cert-err33-c clang-tidy warning (#2968)
* refactor: re-enable cert-err33-c clang-tidy warning
* refactor: use fmt::chrono in transmission-remote
* refactor: use fmt::chrono in transmission-show
* refactor: use fmt::chrono in GTK details dialog
* refactor: use fmt::chrono in tr_session
* refactor: remove tr_localtime_r
* refactor: remove tr_gmtime_r
commit ed897f93f2d764f519fd78ff08148314589f8226
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 13:05:49 2022 -0500
refactor: remove evbuffer_free_to_str() (#2967)
commit 32facb50d72e65ba1e90f82d380f9f9591f3bfbd
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 11:35:56 2022 -0500
refactor: prefer tr_pathbuf over tr_strvPath() (#2966)
commit 7918113e0b1a5c2d8e0be054dfd655474c17da4c
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 09:19:20 2022 -0500
refactor: partially c++ifiy tr_rpc_server (#2965)
Replace the older C-style API methods to be class methods.
commit 3643a8aee512859c3e87048c0bc4922c581b97a7
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 08:08:02 2022 -0500
refactor: prefer std::vector as the default container (#2964)
commit f823df364e3558ba31cc12c409f5306b0451e971
Author: goldsteinn <35538541+goldsteinn@users.noreply.github.com>
Date: Fri Apr 22 06:54:35 2022 -0500
Refactor: use popcnt in bitfield and cleanup warnings (#2950)
Co-authored-by: Noah Goldstein <goldstein.w.n@gmail.com>
commit 4d7d35ad576e578911531bfb39d766227506071d
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 22 01:28:02 2022 -0500
fix: heap-buffer-overflow in variant-json (#2963)
Fixes #2953.
commit 41cb8cbc91075b0ebcf0a4cf7c3ca859cb2640ef
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 21 18:37:02 2022 -0500
refactor: add tr_address.readable (#2962)
commit a25da4f37639c81b0e7a7f85385743a8fad34619
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 21 17:06:00 2022 -0500
refactor: add tr_address::fromCompact() (#2961)
commit a52edbcbbe0ae8686ae80a8d70f022aa700dd273
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 21 15:48:30 2022 -0500
refactor: remove tr_announce_list.tiers (#2960)
commit 68a43c16845302eccf092ef1b3d85d0dced437e4
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 21 12:07:09 2022 -0500
fix: when loading resume state, load filenames before mtimes (#2958)
commit 32f854a7cfd3900990a9cb0b64fc546e18d2ddc8
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 21 10:58:13 2022 -0500
refactor: add a tr_port safety class (#2952)
commit bdac708762993d16a45dcdf966f906f00351cc60
Author: Antoine Cœur <coeur@gmx.fr>
Date: Thu Apr 21 22:28:38 2022 +0800
docs: fix various typos and misspellings (#2955)
commit 0eb1857c6ce3250b6d906668cd785382f69c5f7c
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 19 09:51:25 2022 -0500
build: re-enable cert str34 c clang tidy (#2946)
* build: add clang-analyzer-deadcode.* to clang-tidy
* build: do not disable cert-str34-c checks in libtransmission
commit 345b71ffda932afdc155482d5e6246f176021c1f
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Apr 18 14:24:20 2022 -0500
refactor: use std::vector for tr_torrents.removed_ (#2943)
commit 9c0038ac8e9298b536fa8519117ebf6c0cbd289f
Author: Antoine Cœur <coeur@gmx.fr>
Date: Mon Apr 18 14:03:44 2022 +0800
Pause magnet download when "Start when added" is unchecked (#2902)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 18da7eb12512382ea56d1fc444b8130418d94fa5
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Apr 18 00:53:48 2022 -0500
refactor: use std::vector<tr_quark> for torrent labels (#2942)
commit 3a8cac3914b60416c4b5166d71ab597abcd1c017
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 17 23:21:18 2022 -0500
fix: uninintialized field tr_torrent_files.total_size_ (#2941)
commit af49e0f1af556a2a9d293156fe7d7d09e3797375
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 17 21:55:20 2022 -0500
fix: do not load magnet file resume files (#2940)
commit 1f17ab64beabb9bc36200839e1043fadbe581883
Author: Luukas Pörtfors <lajp@iki.fi>
Date: Mon Apr 18 04:52:58 2022 +0300
remote: Implement rename command (#2905)
* remote: Implement rename command
* use tr_strlcpy
commit fc2f6e97253a8cecfb0a7a8cb303a5043a806733
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 17 17:29:06 2022 -0500
refactor: make tr_peerMgr.webseeds a std::vector (#2937)
commit 9c84e8543257bd7078ce4bb002e59e426f9ff95a
Author: goldsteinn <35538541+goldsteinn@users.noreply.github.com>
Date: Sun Apr 17 11:54:38 2022 -0400
Refactor: Cleanup misc inefficiencies throughout the file (#2933)
Co-authored-by: Noah Goldstein <goldstein.w.n@gmail.com>
commit c1faebca6ea0dd3a4c5c18660dae88d70a990d9c
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 23:36:05 2022 -0500
fix: new MSVC warning in file-piece-map-test.cc (#2936)
commit 3ec7e1933e6779e6039aca6d3aa201216b72a9e5
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 22:23:20 2022 -0500
build: try clang-format-12 in code_style (#2935)
commit d765b7ee3b8cbc1c512d67896494849345f2c9a4
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 21:17:28 2022 -0500
build: pass cmake compiler values to submodules (#2934)
This is needed for consistent building when using compiler-specific
tooling such as address sanitizer flags.
commit 6cdc7e3828e260e70151f26d471f6feda49adbec
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 15:41:51 2022 -0500
refactor: remove tr_announce_list::tracker info.announce (#2931)
commit ef4fcf7ffd6df518fe1e87b91adfbd246f7625f9
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 14:14:18 2022 -0500
refactor: remove tr_announce_list.tracker_info.scrape (#2930)
commit 2f976559817f2d82ab9e11613470b16376f32c3a
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 13:13:42 2022 -0500
refactor: remove tr_url_parsed_t.portstr (#2929)
commit 4a2a6b2985102cd7563f445fe3182264a95806ab
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 11:47:51 2022 -0500
test: use uniform naming scheme for fuzz tests. (#2928)
Use case: libtransmission-test --gtest_filter='*Fuzz' --gtest_repeat N
commit 881860ac6fec86ea51033c4d0bf8accca563ad96
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 16 10:48:51 2022 -0500
refactor: remove tr_torrent.magicNumber (#2927)
commit bafb8d6495056104c7d5275b4f3db5625be23be9
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sat Apr 16 12:02:25 2022 +0800
Trim spaces when using cmd+u sheet (#2915)
commit f4bb09428b8e4b3510956f2ccc224c6b762fdd7d
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 15 19:56:16 2022 -0500
fixup: more libfmt usage regressions (#2924)
commit 2866638e1b3672c897692b7fb10c8e17354ee05c
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 15 18:39:04 2022 -0500
refactor: add tr_torrent_files::move() and remove() (#2919)
commit 4590d172de63d77eccd84c76588ef3703f7d0062
Author: Antoine Cœur <coeur@gmx.fr>
Date: Fri Apr 15 13:38:59 2022 +0800
meta info piece_size should be maximum UINT32_MAX (#2914)
commit 6266533546ee39f8b52ec26e32757cbd7923881c
Author: Antoine Cœur <coeur@gmx.fr>
Date: Thu Apr 14 22:24:10 2022 +0800
Addressing read links in the Xcode project (#2903)
commit 5b6f0a52fd84277b645d37f507494f4265006d14
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 13 23:19:18 2022 -0500
fixup: minor log string formatting changes (#2913)
* fixup! fix: sonarcloud (#2865)
fix: log time format string
* fix: formatting changes
* fixup! refactor: remove tr_strvJoin() (#2896)
fix: daemon logging
Co-authored-by: Catadropa <catadropa@users.noreply.github.com>
commit ec57d10954a0fed1cd21f8b05db49ec61af17a00
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 13 21:41:06 2022 -0500
refactor: tr_files::hasAnyLocalData() (#2911)
commit 9f9f60f1e37e54f408774b700a0b82c2bac10510
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 13 20:22:59 2022 -0500
refactor: tr_block_info (#2908)
commit 4a65956cc91ef8fa65f39603325b7980ce4ddbf9
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 12 10:00:02 2022 -0500
refactor: extract some file management into tr_files class (#2906)
commit 8c51c484722e87a0297c9b2f575623b49f483ede
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 12 01:56:09 2022 -0500
fix: recent FTBFS in msvc (#2907)
* fix: recent FTBFS in msvc
It's happening a line in qt/WatchDir.cc where an enum named `ERROR` is
declared, so it's probably conflicting with a new `ERROR` name in some
header file. Rename ours and make at an `enum class` for good measure.
* build: fix cmake msvc warning
D9025 : overriding /W3 with /W4
commit 7c76d40a4d8748199903cf0a9d7cd0e38ec9e3f1
Author: maxz <6818198+maxz@users.noreply.github.com>
Date: Mon Apr 11 19:38:32 2022 +0200
Improve the documentation (#2900)
* Unify the line endings to the Unix style (LF only).
* Fix (where possible) or remove broken links.
* Improve the documentation.
Fix or remove broken links (depending on whether I could find a
working version of the resource).
Change all links to use HTTPS instead of HTTP.
Unify the capitalizations (e.g. uppercase abbreviations, capitalize
proper names and downcase other words).
Fix or improve some parts of the text, clarifying what is meant.
Improve some parts of the program examples (e.g. only use root
privileges where really required).
commit 70fbce71ec0d5511a2588b0fe438ffba59be12cb
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 9 09:58:02 2022 -0500
refactor: convert watchdir to C++ (#2899)
* refactor: use new/delete instead of malloc/free
* refactor: use std::string instead of raw c strings
commit 205abbbcceed577aa52b9adc0b8ad5097ed0084e
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 7 20:50:26 2022 -0500
refactor: iwyu string, vector, cstdint (#2898)
* refactor: use cstdint for intX_t types
* refactor: iwyu sstring_view
* refactor: iwyu <cstring>
* refactor: iwyu <vector>
commit b256da02e3c13522485317b0473e430c3ba488e4
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 7 19:20:29 2022 -0500
refactor: remove unused macros (#2897)
* refactor: remove unused fu nction tr_lowerBound()
* refactor: tr_timerAdd() takes a reference, not a pointer
* refactor: tr_timerAddMsec() takes a reference, not a pointer
* refactor: tr_moveFile() takes a reference, not a pointer
* refactor: tr_wildmat() takes std::string_views
* refactor: remove unused macro TR_GNUC_NONNULL
* refactor: remove unused macro TR_GNUC_PRINTF
* refactor: remove unused macro TR_GNUC_NULL_TERMINATED
* refactor: remove unused macro TR_GNUC_HOT
* refactor: remove unused macro __has_feature
* refactor: remove unused macro __has_attribute
* refactor: remove unused macro TR_DEPRECATED
* refactor: remove unused macro TR_DISABLE_COPY_MOVE
commit 31c65eec1fc69b94ed72f53217011eb0998e1d85
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 7 17:26:59 2022 -0500
refactor: remove tr_strvJoin() (#2896)
commit ffda5bb68ac18981ced1d8067ca53f234612bca3
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Apr 7 08:23:04 2022 -0500
refactor: remove tr_strip_positional_args() (#2881)
* refactor: use fmt in gtk/SystemIconTray
* refactor: use fmt in gtk/MakeDialog
* refactor: remove unused tr_strip_positional_args()
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
commit 8d11f0bc22ec7e1f87e573d1232e8faa72e745a3
Author: maxz <6818198+maxz@users.noreply.github.com>
Date: Thu Apr 7 00:20:38 2022 +0200
Fix typographical errors in the documentation. (#2889)
commit f79a75cb2114150b1fd9d7c80bdc02c5a512c808
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 6 16:39:39 2022 -0500
test: fuzz test tr_variantFromBuf() (#2892)
* test: fuzz test tr_torrent_metainfo.parseBenc()
* fix: better error-checking in benc string parsing
* fix: return benc failure if the parse stack is unbalanced
* fix: stack range error when logging json parse errors
* test: fuzz test tr_variantFromBuf()
commit a134445caa34904b491f8fdb5750223e237481e0
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 6 15:26:13 2022 -0500
test: fuzz test tr_torrent_metainfo.parseBenc() (#2891)
* test: fuzz test tr_urlParse()
* fix: stack error checking in benc parser
* test: fuzz test tr_torrent_metainfo.parseBenc()
commit e88ebbc3e5d566ca2d5f226ec208e23c99d7d601
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 6 13:22:08 2022 -0500
test: fuzz test tr_magnet_metainfo.parseMagnet() (#2890)
commit eb33b2faf5f99809dc5e68f5782032bdea48b3f2
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Apr 6 12:06:11 2022 -0500
fix: tr_clientForId() (#2887)
* fix: memory corruption when parsing negative numbers
* fix: stack-buffer-overflow on escape chars in tr_clientForId
* test: add tr_clientForId() fuzz tests
commit 7ff13825038cb1af3dc59e224190942f57d0de6b
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Apr 5 12:45:26 2022 -0500
refactor: remove tr_strcmp0() (#2882)
commit 80dd460773ef521acbce18a044162300c68fca0b
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Apr 4 22:51:56 2022 -0500
refactor: annotate nodiscard, constexpr, noexcept methods (#2879)
commit a71f0c762dd227887f437272f5b96503b94a5fa6
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Apr 4 20:37:12 2022 -0500
refactor: remove varargs from libtransmission (#2876)
* refactor: do not use va_arg in peer-msgs.cc
* refactor: do not use va_arg in platform.cc
* build: enable cert-dcl50-cpp clang-tidy warning
* refactor: use some tr_pathbuf where sensible
commit 738431169cce5cc60e935df44d0616891162dee9
Author: maxz <6818198+maxz@users.noreply.github.com>
Date: Mon Apr 4 20:37:35 2022 +0200
Fix typographical errors in the man pages. (#2875)
commit 68bec3f8e3be2c4a5ff11303be1bd5c842f1918b
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Apr 4 13:36:48 2022 -0500
refactor: remove tr_snprintf() (#2872)
commit 32cff6921316b3d1cdcd650619dd3097a06ab0f9
Author: Pierre Carru <pierre@carru.fr>
Date: Mon Apr 4 04:14:44 2022 +0200
torrent-daemon: watchdir can use .magnet files (#1328)
commit d948e49da7a4a19c4dddb0477ff633b942e7a9de
Merge: 1d7d17396 7aeb5d8b2
Author: Mitch Livingston <livings124@mac.com>
Date: Sun Apr 3 14:40:59 2022 -0400
Merge pull request #2870 from nevack/nevack/mojave-infowindow-fix
[macOS] Fix Tab selection in InfoWindow on Mojave
commit 7aeb5d8b2fd54e8a3c7ad26812ba85a0acf8a301
Merge: 7cf920a02 1d7d17396
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 3 13:34:31 2022 -0500
Merge branch 'main' into nevack/mojave-infowindow-fix
commit 1d7d17396f96c0efb1383a4fa5c049c1c378b062
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Apr 3 13:23:00 2022 -0500
refactor: remove tr_snprintf() pt 2 (#2871)
commit 7cf920a020cb031f27d086e4bff09f682a3aef4f
Author: Dzmitry Neviadomski <nevack.d@gmail.com>
Date: Sun Apr 3 16:41:09 2022 +0300
[macOS] Fix Tab selection in InfoWindow on Mojave
Fixes #2599
commit 57b03114dc775c7d1c621fe88e14f6f7a9a5e92f
Author: Gary Elshaw <69029666+GScottElshaw@users.noreply.github.com>
Date: Sun Apr 3 13:08:39 2022 +1200
New images for 'Message Log' (#2779)
commit 76f44b4b6fbf70dd7956e6b0eed063bba8f437bc
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 2 17:42:51 2022 -0500
fix: sonarcloud (#2868)
* refactor: make this variable const
* refactor: replace redundant type with auto
* refactor: use the nullptr literal
* refactor: replace declaration by structured binding declaration
commit 748d3c22237730c0411381f383e3f590da27ff18
Author: Antoine Cœur <coeur@gmx.fr>
Date: Sun Apr 3 04:58:59 2022 +0800
updating googletest (#2858)
commit 392e511f7efd33ee97d3e566f3b9e6bc47eff3f9
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 2 14:34:29 2022 -0500
refactor: remove tr_snprintf() pt 1 (#2867)
* refactor use fmt instead of tr_snprintf in remote.cc
* refactor use fmt instead of tr_snprintf in daemon.cc
* refactor use fmt instead of tr_snprintf in cli.cc
commit 1cc9da26ba4c40c8f8d228b70c5d4c9c6b61eb77
Author: Charles Kerr <charles@charleskerr.com>
Date: Sat Apr 2 09:06:02 2022 -0500
fix: sonarcloud (#2865)
* refactor: implement FileTreeItem::children_ with a std::vector
* fix: std::move should not be called on forwarding reference
* fix: uninitialized scalar variable
* fix: unchecked return value from library
* fix: dereference before null check
* fix: unchecked return value from library
* fix: unchecked return value from library
* fixup! refactor: implement FileTreeItem::children_ with a std::vector
* fix: signed-unsigned comparison in libtransmission tests
* fix: avoid unnecessary copy by using const reference
* fix: function should be declared const
* refactor: use fmt::format to build log timestamps
* fix: use init-statement to reduce variable scope
* fixup! refactor: use fmt::format to build log timestamps
* fix: remove tau_tracker destructor for rule-of-zero
* fix: remove tr_peerIo destructor for rule-of-zero
* Revert "fix: dereference before null check"
This reverts commit cd789678156bb987a8dc6b2eb49cb1db4195d441.
* fix: signed-unsigned comparison in libtransmission tests
* fix: use init-statement to reduce variable scope
* fix: extract nested code block into separate method
* fix: extract nested code block into separate method
* fix: extract nested code block into separate method
* fix: use init-statement to reduce variable scope
* fix: extract nested code block into separate method
* fix: signed-unsigned comparison in libtransmission tests
* fixup! fix: extract nested code block into separate method
* fix: mark possibly-unused as [[maybe_unused]]
* fix: invalid stack memory reference in tr_found_file_t
* fix: signed-unsigned comparison in libtransmission tests
commit 46cc95f72e71cebca660781d8f498287b4cb2bfd
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 21:55:30 2022 -0500
refactor: remove unused functions (#2863)
* refactor: annotate nodiscard, constexpr, noexcept methods
* refactor: remove unused tr_blocklistFileExists()
* refactor: remove unused tr_blocklistFileIsEnabled()
* refactor: remove unused tr_ctorGetContents
* refactor: remove unused tr_error_is_set()
* refactor: remove unused tr_handshakeGetAddr()
* refactor: remove unused tr_ctorSetLabels()
* refactor: remove unused tr_http_escape_sha1()
* refactor: remove unused tr_lpdEnabled()
* refactor: remove unused tr_ptrArrayPop()
* refactor: remove unused tr_torrentClearIdleLimitHitCallback()
* refactor: remove unused tr_torrentFindFromHash()
* refactor: remove unused tr_sha1_to_string()
* refactor: remove unused tr_torrents::get()
* refactor: remove unused tr_isEncryptionMode()
* refactor: remove unused tr_isPreallocationMode()
* refactor: remove unused tr_ptrArrayBack()
* refactor: remove unused tr_ptrArrayClear()
* refactor: remove unused tr_torrents::get()
* refactor: remove unused Session::torrentSet()
* refactor: remove unused peer_atom comparison operators
* refactor: remove unused peer_atom::compare()
* refactor: remove unused Qt variantInit(tr_variant*, unsigned)
commit ca5799a4a86422749111f8ad8cb86825eabc9958
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 19:48:09 2022 -0500
refactor: annotate nodiscard, constexpr, noexcept methods (#2862)
commit 33cbe33229478033b19df18cf7af06b8ef9633ed
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 18:00:51 2022 -0500
refactor: remove varargs from TR_ASSERT_MSG() (#2861)
commit bfd7797c5e8299893168da538f65072f47a8d777
Author: SweetPPro <sweetppro@users.noreply.github.com>
Date: Fri Apr 1 22:28:55 2022 +0200
fix: magnet link metainfo corrupted on restart (#2790)
commit a250690f30b36a509b969d8785708380f7dbda3f
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 14:16:33 2022 -0500
fix: sonarcloud (#2860)
* fix: break will never be executed
* fix: rewrite rimraf() to be non-throwing
* fix: conditional operation returns same value whether condition is true or false
* fix: use std::array instead of a C-style array
* fix: remove redundant access specifier
* fix: replace switch with if for readability
* fix: convert integer literal to a bool literal
* fix: replace const std::string reference to std::string_view
* fix: remove redundant access specifier
* fix: replace const std::string reference to std::string_view
* fix: remove unused parameter
* fix: remove redundant access specifier
* fix: use std::array instead of C-style array
* fix: remove redundant access specifier
* fix: replace const std::string reference with std::string_view
* fix: remove redundant access specifier
* fix: use std::array instead of C-style array
* fix: remove redundant access specifier
* fix: replace const std::string reference to std::string_view
* fix: remove redundant access specifier
* fix: merge if statement with enclosing one
* chore: clang-format
* chore: clang-format
* Revert "fix: remove redundant access specifier"
This reverts commit 054e4e7eecbbc6d1108fd15de10f39cd8aad2aa6.
* Revert "fix: remove redundant access specifier"
This reverts commit 2c92f227e8220447a5a2658c758c61888d5a62a1.
* Revert "fix: remove redundant access specifier"
This reverts commit a0710202a8195a8617f454f21450040d8ae07813.
* Revert "fix: remove redundant access specifier"
This reverts commit 54da1d93972f662697a2811631d9760757319abc.
* Revert "fix: remove redundant access specifier"
This reverts commit f7b1777578acf0caa5f5b87af0b5715b0a0d1c1a.
* Revert "fix: remove redundant access specifier"
This reverts commit ad8e3dfff4a7fb41a7d14ed30759317f7f77b455.
* chore: revert access specifier change
commit 6da591fe5780ad1456bcca363cdfedd093193895
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 11:29:05 2022 -0500
fixup! refactor: use fmt to build the GTK client's user-visible strings (#2788) (#2859)
fix: formattted speeds and percentages
commit 1f15933fda9894d5ec5b86089fe65bc73c9d4029
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Apr 1 08:49:54 2022 -0500
fix: incorrect magnet size calcuation in tr_completion (#2856)
commit e64430941fcd0991e651a8cf3859e682a3232b1e
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 31 19:13:37 2022 -0500
refactor: remove tr_strdup_printf() (#2854)
commit 995012aaa99b25cca87d35251b7a2c8a3d86ca5d
Author: beizmos <36188230+foobar-d@users.noreply.github.com>
Date: Thu Mar 31 16:53:21 2022 -0400
updated docs/Port-Forwarding-Guide.md (#2847)
* Add files via upload
- added guide for Windows
- cleaned up
* Update Port-Forwarding-Guide.md
minor fixes
* Updated Port-Forwarding-Guide.md
added note port router port mapping
* Update Port-Forwarding-Guide.md
added note about opening ports in windows
* Update Port-Forwarding-Guide.md
ip a command for unix
* Update Port-Forwarding-Guide.md
rewording, grammatical fixes, syntax
commit 98e8d5a3daa0700ce2cef67e556f5863851c418e
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 31 15:07:01 2022 -0500
fix: getBandwidthGroup use right group (#2853)
Fixes #2828.
commit 946cf04833aa8cca73dc5d406dac29337fa5cc72
Author: Matan Ziv-Av <matan@svgalib.org>
Date: Thu Mar 31 21:35:21 2022 +0300
Bandwidth group are written to a dict, not to a list. (#2852)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 6e91136b53ff8acd6055e85bc0341e350f6b7111
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 31 12:12:54 2022 -0500
fix: three asan issues (#2851)
* fixup! feat: add support for adding torrents by raw hash values (#2608)
fix array-bounds-read issue found by asan
* fixup! refactor: tr_completion (#2220)
fix array-bounds-read issue in tests fixtures
* fixup! refactor: tr_torrents (#2722)
fix memory leak in torrent-tests
commit d943f069f5f40155e6adb3f9577114f38e2759ce
Author: Mike Gelfand <mikedld@users.noreply.github.com>
Date: Thu Mar 31 00:52:23 2022 +0300
Fix code_style.sh to include *.mm files after switch to Obj-C++ (#2846)
commit e4461c48d7073a49c007ba776734ce851487c17e
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Mar 30 14:59:13 2022 -0500
refactor: prefer FMT_STRING (#2845)
* use FMT_STRING in libtr client on non-i18n strings
This gives compile-time safety checks.
commit f4afb766954c63579b09816b3163561c5ab8c604
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Mar 30 13:25:41 2022 -0500
perf: replace tr_torrentFindFile2() with tr_torrrent.findFile() (#2839)
commit 4dd25d81121235f6088ae96904a57cabea9ca116
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Mar 30 12:10:51 2022 -0500
fix: tr_strbuf move op loses zero-termination (#2843)
commit 66638cc80cc1f45c5c3614b46f97d048bb30393e
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Mar 30 01:30:39 2022 -0500
test: fix race condition in move-test (#2841)
commit 3dadeae700811372b4e9d1d298841111e1f33339
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Mar 29 20:52:24 2022 -0500
fix: file progress in GTK Details dialog (#2838)
commit f1a028bb84b20924e19d634198d2dc7bab317834
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Mar 29 10:27:34 2022 -0500
chore: revert 2f677aebb assertion
commit 4177e286a1fc20a48c1eb26ca5e7cf5d5713b7ff
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Mar 29 05:57:04 2022 -0500
fix: sonarcloud (#2837)
* fix: rename variable to avoid shadow warning w/UTP
* fix: add default dtor for tr_strbuf
* fix: implicit conversion may lose precision
* fix: use init-statement to reduce variable scope
* fix: implicit conversion may lose precision
* fix: extract the assignment from this expression
* fix: use init-statement to reduce variable scope
* fix: use init-statement to reduce variable scope
* fix: do not mix public and private data members
* fix: add a condition to cv.wait call
* fix: do not throw uncaught exceptions in destructor
commit 2f677aebb0b507623ae2c2614e55e136540cf49a
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Mar 28 23:29:35 2022 -0500
refactor: add tracer assertionf or bug #2727 (#2836)
commit 2996e223dd9a754e6c309bdf3df2545cfd67d321
Author: Charles Kerr <charles@charleskerr.com>
Date: Mon Mar 28 17:13:32 2022 -0500
refactor: strbuf for metainfo files (#2833)
* refactor: tr_ctorSaveContents takes a string_view filename
* refactor: remove tr_ctorSaveMagnetContents
* refactor: announce_list::save takes a std::string_view
* refactor: magnet() takes an OutputIt arg
Generate the magnet link URL into an output iterator
* refactor: remove deprecated calls to tr_http_escape
* refactor: tr_torrent.torrentFile takes an OutputIterator
* refactor: tr_torrent.torrentFile returns a tr_pathbuf
* refactor: tr_torrent_metainfo.makeFilename returns a tr_pathbuf
* refactor: use tr_urlbuf in announcer-http
commit 3ddf76b5607b6455b22e465b49b55f023a918432
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Mar 28 08:10:46 2022 -0500
build(deps): bump minimist from 1.2.5 to 1.2.6 in /web (#2831)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 25f2216dd47650223ee834ec5b2a9a40a5cbf7a0
Author: Matan Ziv-Av <matan@svgalib.org>
Date: Mon Mar 28 07:43:28 2022 +0300
Allow control of transmission-show output (#2825)
- Add flags to control each of the four sections of output (header, info, trackers, files).
- Add a flag to show file size in bytes, instead of human readable units (KiB, MiB, GiB, TiB).
commit 9d141ee2b15c7e50d4063056ce1da9ad91adc37d
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Mar 27 21:55:30 2022 -0500
refactor: add fmt::formatters (#2829)
* refactor: add fmt::formatters
commit 71ad42b1efc67904d046fde3f54617c5ad2f7dd0
Author: Charles Kerr <charles@charleskerr.com>
Date: Sun Mar 27 12:37:29 2022 -0500
refactor: make err arg optional in tr_sys_* funcs (#2827)
commit 3cd11ee1fbb9783144ab7058eb0c55f5c3190664
Author: Mike Gelfand <mikedld@mikedld.com>
Date: Sun Mar 27 03:45:10 2022 +0100
Fix USE_QT_VERSION CMake option
commit c2549c3c774a93df5e1c80570f3696655519f0d0
Author: Mike Gelfand <mikedld@mikedld.com>
Date: Sun Mar 27 00:05:55 2022 +0000
Remove CPack symlinks workaround
Looks like it was a CMake defect.
commit 4c2cb23c245b3d09ab3efb47206c9429d65ccaee
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 22:39:08 2022 -0500
refactor: tr_variantToFile() takes a string_view filename (#2824)
* chore: fix shadowed variable warning
"byte" is declared by a third-party UTP header
* refactor: tr_variantFromFile, tr_variantToFile take a string_view filename
commit 45422a2ac5f38fa4fe816a526e41178cd14be0db
Author: Matan Ziv-Av <matan@svgalib.org>
Date: Sat Mar 26 04:31:59 2022 +0300
Add support for group-get RPC call to transmission-remote (#2818)
Option `-lg` lists all bandwidth groups with their bandwidth limits.
commit 977b2a1bab08f4e1f8a878ab56548d88a6ec2b30
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 19:31:27 2022 -0500
refactor: tr_loadFile() tr_saveFile() take a std::string_view filename arg (#2822)
* refactor: tr_saveFile takes a string_view
* refactor: tr_saveFile, tr_loadFile take string_view filename
commit 1051160b99f94bf81e0cfde89819656001266127
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 16:16:26 2022 -0500
feat: strbuf features (#2821)
* feat: strbuf is always zero-terminated
* feat: tr_strbuf::append() now takes any number of args
* feat: tr_strbuf handles zero-terminated string inputs
* feat: add tr_strbuf::ends_with()
* feat: add tr_strbuf::starts_with()
* refactor: replace buildPath() with join()
commit 9451446e6d0f64d6e6a6b15545568be3618d5286
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 14:14:27 2022 -0500
fix: set the destructor log level to trace (#2820)
Fixes #2816.
commit 7905244320901f3b244315ee4180ffc196a8c3b8
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 12:16:29 2022 -0500
fix: missing fmt::arg calls in GTK client (#2819)
commit b94c6796c872d42f3cae2a245c04d7d20bddffc0
Author: Charles Kerr <charles@charleskerr.com>
Date: Fri Mar 25 00:24:04 2022 -0500
fix: sonarcloud warnings (#2815)
* fix: add default case to switch statement
* fix: remove redundant static specifier
* fix: use std::optional.value_or
* fix: make type of variable pointer-to-const
* refactor: move log state into a struct
* refactor: make tr_peerMgr constructor explicit
* fix: make type of variable pointer-to-const
* fix: replace insert with try_emplace
* fix: implicit conversion may lose precision
* fix: use init-statement to reduce variable scope
* chore: mark unused return value with (void)
commit 0a8cfba3b3bce887562426d2125a75b726ddd17e
Author: Ali <azy5030@gmail.com>
Date: Thu Mar 24 22:26:21 2022 -0500
Add ability to change piece size during torrent creation in MacOS GUI… (#2805)
* Add ability to change piece size during torrent creation in MacOS GUI (#2416)
* Shouldn't have committed the xcodeproj file
commit cf6f279830f3e53ecb6eee3d7cdc23ee9a286b9f
Author: JP-Ellis <josh@jpellis.me>
Date: Fri Mar 25 13:14:11 2022 +1100
Fix finding system PSL library (#2812)
Whilst the library file my be called `libpsl`, CMake expects there to be a `lib` in front and thus the existing code was actually looking for `liblibpsl`.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit bd895b50526665c4c379a5670105cafe017d2ad1
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 24 19:03:15 2022 -0500
test: fix file-info test edge case (#2811)
commit 6e8f9f3ff08d1878ec272339384c8c6a8e0449b1
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 24 16:41:29 2022 -0500
feat: add tr_strbuf (#2810)
* feat: add tr_strbuf class for building tmp strings
Based on fmt::basic_memory_buf, this is a growable string buffer that
has an initial size that's large enough to build most filenames or URLs
without needing heap allocations.
Adds a couple of extra helpers such as a `c_str()` method to make dealing
with old zero-terminated string APIs easier.
commit 783fa500e7a7575de27c5d4d74fbcdee2da06eac
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 24 13:46:34 2022 -0500
fix: set the utp state change log level to trace (#2809)
Fixes #2808.
commit f19c09ad9bcc361d9cccdf83ef6ce756595910a7
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 24 08:31:00 2022 -0500
fix: bugprone-narrowing-conversions warnings in bitfield.cc (#2806)
commit b8c3778cf47017bf6d490b93b72bda37d8052fd7
Author: Charles Kerr <charles@charleskerr.com>
Date: Thu Mar 24 00:18:41 2022 -0500
fix: sonarcloud warnings (#2804)
* fix: break will never be executed
* refactor: compile the name fallback string
* fix: replace redundant type with auto
* fix: use init-statement to reduce variable scope
* fix: implicit conversion loses precision
* fix: use in-class initializer
* fix: make variable a pointer-to-const
* fix: local variable name shadows class variable
* fix: implicit conversion may lose precision
commit 6db3fbfe64803ec178c191fcf78600603ec48f56
Author: Charles Kerr <charles@charleskerr.com>
Date: Wed Mar 23 22:02:18 2022 -0500
perf: tell curl_share to share everything (#2802)
commit 791f59e8ba3f4feb2d36adb9bb56fadae9f40586
Author: SweetPPro <sweetppro@users.noreply.github.com>
Date: Wed Mar 23 16:18:06 2022 +0100
fix for editing magnet link tracker list (#2793)
Co-authored-by: SweetPPro <sweetppro@users.noreply.github.com>
commit 53dc3a41b486d0369b296d3d2277d7da4085e45a
Author: David Beinder <david.beinder@gmail.com>
Date: Tue Mar 22 20:01:07 2022 +0100
fix: return correct bitfield when fully downloaded (#2799)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
commit 04a4f4a10cce56eac114155841012e712ca6ec5f
Author: Charles Kerr <charles@charleskerr.com>
Date: Tue Mar 22 11:45:56 2022 -0500
refactor: a little more logging (#2800)
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subjective design change.
It helps discoverability of this feature. For the little story, I created #2849 because I didn't know that this feature existed.