Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked images for Message Log w/ added bonus 'Empty' Group icon #3067

Closed
wants to merge 17 commits into from
Closed

Conversation

GaryElshaw
Copy link
Contributor

@GaryElshaw GaryElshaw commented May 8, 2022

I was never particularly happy with the last lot of images i created, particularly the outer edges, so an update. I've also included White and Grey icon sets for any future project needs.

With #3065 a new circular 'Empty' icon was needed for Group.

@GaryElshaw GaryElshaw changed the title Reworked images for Message Log Reworked images for Message Log w/ added bonus 'Empty' Group icon May 9, 2022
@GaryElshaw
Copy link
Contributor Author

@mikedld Mike, could you give some TLC to TC please?

@Coeur Coeur self-assigned this May 14, 2022
@Coeur
Copy link
Collaborator

Coeur commented May 14, 2022

This PR is, presently, a combination of two changes:

  1. GroupsNoneTemplate.png, which is the empty group icon;
  2. *DotFlat.png, which are the message logs icons (which users rarely visit).

One issue from the usage of .png files is that it's not ideal for supporting both light mode and dark mode.
Considering the uniform content of those icons, I feel we can simply render them programmatically.

@GaryElshaw
Copy link
Contributor Author

Sheesh Antoine, thanks for minimising my contributions :-(

@Coeur
Copy link
Collaborator

Coeur commented May 14, 2022

Hi @GaryElshaw
Thanks to you, I'm discovering features and ways to improve them.
I'll give a try to the icons generation.

@GaryElshaw
Copy link
Contributor Author

GaryElshaw commented May 15, 2022

@Coeur I totally agree with you that this would be great if it was done in code, especially for the OS versions with Light and Dark options.

I don't know what is currently possible for 4.0, but this is high on my feature list, and it seems i'm not alone after looking in the forums. In the interim, i have a local branch that alters a bunch of source files to increase font sizes. #1676

Which raises a separate discussion i've wanted to have with contributors and maintainers alike for a while, because i have too much time on my hands...
#3089

@GaryElshaw GaryElshaw closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants